Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

164 - Extract camera scanner from core library #175

Closed

Conversation

VincentKobz
Copy link
Collaborator

  • Create a maven artifact scanner-camera, which contains all camera-related classes (camera SDK and camera activity)
  • Refactor ScannerCompatActivity: remove all camera-related mechanisms (goToCamera, layoutIdCamera, cameraViewId, cameraScanner) and camera-specific permissions. All these mechanisms are inside a new activity .
  • Create CameraCompatActivity in scanner-camera (com.enioka.scanner.sdk.camera), that contains a basic layout for the camera, as an Android activity. Contains the entire camera part previously located in ScannerCompatActivity.
  • Update the ReadTheDocs documentation to match the new API.

Change inside ScannerCompatActivity:

  • The ScannerCompatActivity can automatically or manually (with a toggle button) fallback to the CameraCompatActivity via an explicit Android intent if the maven artifact scanner-camera is included, otherwise there is no camera-as-scanner functionality.
  • Interaction buttons for scanners will now be disable if no scanner provider is found.
  • Camera toggle button only shows if the camera SDK is found.

It is now possible to use only the default camera activity layout without the scanner activity layout.

The entire camera scanner API is still accessible, via the scanner-camer artifact.

@VincentKobz VincentKobz requested a review from DaSpood April 18, 2024 15:09
@VincentKobz VincentKobz self-assigned this Apr 18, 2024
@DaSpood
Copy link
Collaborator

DaSpood commented Apr 30, 2024

Replaced by #176

@DaSpood DaSpood closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants