Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to 1.20.5 #21

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Port to 1.20.5 #21

merged 2 commits into from
Apr 26, 2024

Conversation

Benonardo
Copy link
Contributor

Note: the Cooldown Coordinator dependency currently relies on maven local, you need to mirror 0.7.0 on your maven for actions to work.

Remember to merge in a new branch :shipit:

@gniftygnome
Copy link
Contributor

You can get CC from GH. It's just a bit annoying since GH can't seem to figure out how to make public maven.

repositories {
    maven {
        url "https://maven.pkg.github.com/gniftygnome/cooldown-coordinator"
        credentials {
            username = project.findProperty("gpr.user") ?: System.getenv("USERNAME")
            password = project.findProperty("gpr.key") ?: System.getenv("TOKEN")
        }
    }
}
dependencies {
    modImplementation "net.gnomecraft:cooldown-coordinator:${project.cooldowncoordinator_version}"
}

@enjarai
Copy link
Owner

enjarai commented Apr 26, 2024

You can get CC from GH. It's just a bit annoying since GH can't seem to figure out how to make public maven.

repositories {
    maven {
        url "https://maven.pkg.github.com/gniftygnome/cooldown-coordinator"
        credentials {
            username = project.findProperty("gpr.user") ?: System.getenv("USERNAME")
            password = project.findProperty("gpr.key") ?: System.getenv("TOKEN")
        }
    }
}
dependencies {
    modImplementation "net.gnomecraft:cooldown-coordinator:${project.cooldowncoordinator_version}"
}

I prefer my mod to be compilable easily, the github maven is too annoying to work with imo. Thats why I've been mirroring CC on my mirrors maven for a while now, I hope you don't mind.

@enjarai enjarai changed the base branch from 1.20.4/dev to 1.20.5/dev April 26, 2024 12:27
@enjarai enjarai merged commit 6a4d5c9 into enjarai:1.20.5/dev Apr 26, 2024
0 of 2 checks passed
@gniftygnome
Copy link
Contributor

Thats why I've been mirroring CC on my mirrors maven for a while now, I hope you don't mind.

I don't mind at all; just wanted to provide another option. Having to log in to GH for their maven is stupid but that's GH. I'm also sure I could get Prospector to set it up so I could upload CC to the Terraformers maven; I just never seem to get around to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants