ApiDescriptor rename slash-api to mount #10755
#10756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10756 +/- ##
=========================================
Coverage 84.57% 84.57%
- Complexity 20012 20013 +1
=========================================
Files 2639 2639
Lines 69437 69438 +1
Branches 5602 5602
=========================================
+ Hits 58724 58726 +2
Misses 8006 8006
+ Partials 2707 2706 -1 ☔ View full report in Codecov by Sentry. |
rymsha
requested changes
Nov 4, 2024
|
|
||
| private ApiDescriptor( final Builder builder ) | ||
| { | ||
| Preconditions.checkNotNull( builder.key, "key cannot be null" ); | ||
|
|
||
| this.key = builder.key; | ||
| this.allowedPrincipals = builder.allowedPrincipals; | ||
| this.allowedPrincipals = Objects.requireNonNullElseGet( builder.allowedPrincipals, () -> PrincipalKeys.from( RoleKeys.EVERYONE ) ); |
anatol-sialitski
force-pushed
the
issue-10755
branch
from
a9f3a70 to
7d34ac8
Compare
anatol-sialitski
force-pushed
the
issue-10755
branch
from
7d34ac8 to
c02dd2e
Compare
rymsha
requested changes
Nov 5, 2024
modules/core/core-api/src/main/java/com/enonic/xp/api/ApiDescriptor.java
Show resolved
Hide resolved
| } | ||
|
|
||
| public boolean isAccessAllowed( final PrincipalKeys principalKeys ) | ||
| { | ||
| return allowedPrincipals == null || principalKeys.contains( RoleKeys.ADMIN ) || | ||
| allowedPrincipals.stream().anyMatch( principalKeys::contains ); | ||
| return allowedPrincipals.stream().anyMatch( principalKeys::contains ); |
There was a problem hiding this comment.
admin role should always have access, regardless of what descriptor says
anatol-sialitski
force-pushed
the
issue-10755
branch
from
c02dd2e to
9262a9b
Compare
anatol-sialitski
force-pushed
the
issue-10755
branch
from
9262a9b to
4ff0579
Compare
rymsha
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.