Clean up credentials file after E2E job. (#11285)

- While #11255 fixes the root cause of #11278, this PR fixes what triggered it - since #11198 our runners were keeping `~/.enso/credentials` file between runs, meaning that some tests were unexpectedly running in 'authenticated' mode. This PR cleans up this file to avoid that.
enso-org · Oct 9, 2024 · 669ac97 · 669ac97
1 parent 7f5c0e6
commit 669ac97
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/.github/workflows/gui.yml b/.github/workflows/gui.yml
@@ -372,6 +372,9 @@ jobs:
           ENSO_TEST_USER: ${{ secrets.ENSO_CLOUD_TEST_ACCOUNT_USERNAME }}
           ENSO_TEST_USER_PASSWORD: ${{ secrets.ENSO_CLOUD_TEST_ACCOUNT_PASSWORD }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      - run: rm $HOME/.enso/credentials
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       - if: failure() && runner.os == 'Windows'
         name: List files if failed (Windows)
         run: Get-ChildItem -Force -Recurse
@@ -441,6 +444,9 @@ jobs:
           ENSO_TEST_USER: ${{ secrets.ENSO_CLOUD_TEST_ACCOUNT_USERNAME }}
           ENSO_TEST_USER_PASSWORD: ${{ secrets.ENSO_CLOUD_TEST_ACCOUNT_PASSWORD }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      - run: rm $HOME/.enso/credentials
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       - if: failure() && runner.os == 'Windows'
         name: List files if failed (Windows)
         run: Get-ChildItem -Force -Recurse
@@ -506,6 +512,9 @@ jobs:
           ENSO_TEST_USER: ${{ secrets.ENSO_CLOUD_TEST_ACCOUNT_USERNAME }}
           ENSO_TEST_USER_PASSWORD: ${{ secrets.ENSO_CLOUD_TEST_ACCOUNT_PASSWORD }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      - run: rm $HOME/.enso/credentials
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       - if: failure() && runner.os == 'Windows'
         name: List files if failed (Windows)
         run: Get-ChildItem -Force -Recurse

diff --git a/build/build/src/ci_gen/job.rs b/build/build/src/ci_gen/job.rs
@@ -547,6 +547,16 @@ impl JobArchetype for PackageIde {
                     "ENSO_TEST_USER_PASSWORD",
                 );
             steps.push(test_step);
+
+            // After the E2E tests run, they create a credentials file in user home directory.
+            // If that file is not cleaned up, future runs of our tests may randomly get
+            // authenticated into Enso Cloud. We want to run tests as an authenticated
+            // user only when we explicitly set that up, not randomly. So we clean the credentials
+            // file.
+            let cloud_credentials_path = "$HOME/.enso/credentials";
+            let cleanup_credentials_step = shell(format!("rm {cloud_credentials_path}"));
+            steps.push(cleanup_credentials_step);
+
             steps
         })
         .build_job("Package New IDE", target)