Allow duplicate on local backend

enso-org · Sep 25, 2024 · af3db4e · af3db4e
1 parent 56d1b00
commit af3db4e
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 22 deletions.
diff --git a/app/dashboard/src/layouts/AssetsTable.tsx b/app/dashboard/src/layouts/AssetsTable.tsx
@@ -76,7 +76,7 @@ import type Backend from '#/services/Backend'
 import * as backendModule from '#/services/Backend'
 import LocalBackend, * as localBackendModule from '#/services/LocalBackend'
 import * as projectManager from '#/services/ProjectManager'
-import RemoteBackend, { isSpecialReadonlyDirectoryId } from '#/services/RemoteBackend'
+import { isSpecialReadonlyDirectoryId } from '#/services/RemoteBackend'
 
 import { ErrorDisplay } from '#/components/ErrorBoundary'
 import { useEventCallback } from '#/hooks/eventCallbackHooks'
@@ -1839,7 +1839,6 @@ export default function AssetsTable(props: AssetsTableProps) {
           })
           setModal(
             <DuplicateAssetsModal
-              canUpdate={backend instanceof RemoteBackend}
               parentKey={event.parentKey}
               parentId={event.parentId}
               conflictingFiles={conflictingFiles}

diff --git a/app/dashboard/src/modals/DuplicateAssetsModal.tsx b/app/dashboard/src/modals/DuplicateAssetsModal.tsx
@@ -46,17 +46,11 @@ export interface DuplicateAssetsModalProps {
   readonly nonConflictingProjectCount: number
   readonly doUploadNonConflicting: () => void
   readonly doUpdateConflicting: (toUpdate: ConflictingAsset[]) => void
-  /**
-   * Whether the user can update the assets.
-   * Usually it's not possible to update assets in local backends.
-   * @default true
-   */
-  readonly canUpdate?: boolean
 }
 
 /** A modal for creating a new label. */
 export default function DuplicateAssetsModal(props: DuplicateAssetsModalProps) {
-  const { conflictingFiles: conflictingFilesRaw, canUpdate = true } = props
+  const { conflictingFiles: conflictingFilesRaw } = props
   const { conflictingProjects: conflictingProjectsRaw, doUpdateConflicting } = props
   const { siblingFileNames: siblingFileNamesRaw } = props
   const { siblingProjectNames: siblingProjectNamesRaw } = props
@@ -200,7 +194,7 @@ export default function DuplicateAssetsModal(props: DuplicateAssetsModalProps) {
                 className="relative"
               />
             </div>
-            {count > 1 && canUpdate && (
+            {count > 1 && (
               <ariaComponents.ButtonGroup>
                 <ariaComponents.Button
                   variant="outline"
@@ -261,18 +255,17 @@ export default function DuplicateAssetsModal(props: DuplicateAssetsModalProps) {
         )}
 
         <ariaComponents.ButtonGroup className="relative">
-          {canUpdate && (
-            <ariaComponents.Button
-              variant="submit"
-              onPress={() => {
-                doUploadNonConflicting()
-                doUpdateConflicting([...conflictingFiles, ...conflictingProjects])
-                unsetModal()
-              }}
-            >
-              {count === 1 ? getText('update') : getText('updateAll')}
-            </ariaComponents.Button>
-          )}
+          <ariaComponents.Button
+            variant="submit"
+            onPress={() => {
+              doUploadNonConflicting()
+              doUpdateConflicting([...conflictingFiles, ...conflictingProjects])
+              unsetModal()
+            }}
+          >
+            {count === 1 ? getText('update') : getText('updateAll')}
+          </ariaComponents.Button>
+
           <ariaComponents.Button
             variant="accent"
             onPress={() => {