-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DB_Table feature flags #11163
Add DB_Table feature flags #11163
Conversation
bdd14b5
to
c798c7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like the approach puts the responsibility in correct place.
Approving but have left some suggested changes.
distribution/lib/Standard/Microsoft/0.0.0-dev/src/Internal/SQLServer_Dialect.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Microsoft/0.0.0-dev/src/Internal/SQLServer_Dialect.enso
Outdated
Show resolved
Hide resolved
test/Table_Tests/src/Common_Table_Operations/Aggregate_Spec.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Microsoft/0.0.0-dev/src/Internal/SQLServer_Dialect.enso
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
I especially appreciate the tests that ensure that if a feature is unsupported, it raises an informative error instead of crashing/returning garbage - these seem really useful.
I imagine we will need to increase granularity of the feature flags in next iterations, but that looks like a great starting point.
Only thing I don't really agree with is disabling DB_Table.at
- IMO it should still be allowed, just operations on columns should raise an error. I should still be able to do my_table.at "my_column" . to_vector
in basically any backend that supports 'Read table' feature. But open to being convinced otherwise :)
Pull Request Description
This MR:
Important Notes
Note the current set of flags may not be the final set and some of the flagging out of tests is probably coarser than it will eventually be. As we work through SQLServer enbaling functionality and tests we will clean these up.
Next steps after this MR will be:
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.