Run node in a different execution environment

[4e6]

Pull Request Description

close #10719

Changelog:

• add: optional expressionConfigs parameter to the executionContext/recompute request
• update: IdExecutionInstrument allowing to run a single node in a specified execution environment
• refactor: move tests related to the recompute request to a separate test suite. Otherwise the RuntimeServerTest is becoming too bloated

Important Notes

The updated executionContext/recompute request.

interface ExecutionContextRecomputeParameters {
  /** The execution context identifier. */
  contextId: ContextId;

  /** The expressions that will be invalidated before the execution.
   *
   *  Only the provided expression ids are invalidated excluding the dependencies.
   */
  invalidatedExpressions?: "all" | ExpressionId[];

  /** The execution environment that will be used in the execution. */
  executionEnvironment?: ExecutionEnvironment;

  /** The execution configurations for particular expressions.
   *
   *  The provided expressions will be invalidated from the cache with the
   *  dependencies. The result of the execution will stay in the cache until the
   *  cache is invalidated by editing the node or other means.
   */
  expressionConfigs?: ExpressionConfig[];
}

interface ExpressionConfig {
  /** The expression identifier. */
  expressionId: ExpressionId;
  /** The execution environment that should be used to run this expression. */
  executionEnvironment?: ExecutionEnvironment;
}

Use cases

• to re-run a single node without re-running the dependent nodes (subtree), put the node id in the invalidatedExpressions parameter.
• to re-run a node with dependent nodes (subtree), put the node id in the expressionConfigs parameter with empty executionEnvironment
• to re-run a node in a different execution environment, put the node id in the expressionConfigs and specify the executionEnvieronment

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

• The documentation has been updated, if necessary.
• All code follows the
  Scala,
  Java,
  TypeScript,
  and
  Rust
  style guides. In case you are using a language not listed above, follow the Rust style guide.
• Unit tests have been written where possible.

[JaroslavTulach]

Use ContextThreadLocal.

[hubertp]

lgtm

[hubertp]

How is the null condition even possible?

[4e6]

I remember I added this guard to fix NPE. But I don't remember exactly how the null value appears

[JaroslavTulach]

No, we do not want to expose getRootNode(). It is only used by:

EnsoContext context = EnsoContext.get(info.getRootNode());
originalExecutionEnvironment = context.getExecutionEnvironment();

and corresponding setter. Just call it getExecutionEnvironment() and setExecutionEnvironment.

Btw. There already is setExceptionEnvironment below why we have two ways of doing the same thing? Can you document the methods and describe different among them?

[JaroslavTulach]

I don't like the statefulness kept inside of the IdExecutionService. Rather than that let the only service only suggest a change of environment by having a method like:

StringOrSomeEnvironmentType findExecutionEnvironment(Info);

and then let all the work of enabling it and especially disabling it in the IdExecutionInstrument itself.

That will simplify the API to a single method and we can remove getRootNode and other new methods.

[JaroslavTulach]

The IdExecutionService interface with single method addition looks fine. Few more comments on the engine&instrument side.

[JaroslavTulach]

Ech. Thread.sleep doesn't belong into programs and it is better to avoid them in tests too. Please replace with proper wait/notify primitives:

context.waitForOut(200);

that will be notified immediately as soon as some output is delivered.

[4e6]

The output is updated from the Enso program. How do you notify the waiting method in the test?

[JaroslavTulach]

Why is this variable in the EnsoLanguage and not in EnsoContext?

[4e6]

Context thread local references must be created during the invocation in the TruffleLanguage constructor.

https://www.graalvm.org/truffle/javadoc/com/oracle/truffle/api/TruffleLanguage.ContextLocalProvider.html#createContextThreadLocal(com.oracle.truffle.api.TruffleLanguage.ContextThreadLocalFactory)