Dashboard improvements (from 24 September 2024 + 30 September 2024) #11219

somebody1234 · 2024-10-01T08:44:31Z

Pull Request Description

Close https://github.com/enso-org/cloud-v2/issues/1508
- ⚠️ Labels modal - add selection indicator where user can (de)select multiple labels
  - Checkboxes currently still cause the dialog to (incorrectly) close
- Edit datalink -> select enso secret -> options are too narrow for enso path. Strip enso://Users(Teams), if possible make the options list longer on the left side
  - Added (or rather, re-enabled via CSS) horizontal scroll instead
- Make Versions, Sessions, Settings as tabs similar to documentation panel in graph editor
- Edit description in context menu should open asset panel with description input active
- Edit secret should be moved to asset panel (same like datalink)
- Dim background when "edit description", "edit secret", or "edit datalink" are clicked/triggered via shortcut to highlight input
- Hide unused (= no backend support) columns and icons: accessed by projects and accessed data
Partial frontend fixes for https://github.com/enso-org/cloud-v2/issues/1529
- (1) Fix settings title being horizontally centered and split on multiple lines
- (2) ❌ backend issue
- (3) ❌ out of scope
- (4) ❌ backend issue
- (5) ❌ out of scope
- (6) ❌ out of scope
- (7) ❌ backend issue
- (8) ❌ already fixed in Fix rest of user/team permissions checks and "new label" dialog #11126
- (9) ❌ out of scope (potentially requires a way to trigger a tooltip on a disabled button)
- (10) ❌ out of scope
- (11) ❌ out of scope
- (12) ❌ out of scope
- (13) URL encode enso:// URLs in "copy as path"
- (14) Double click on datalink make asset open and close (not sure if this has already been fixed)
- (15) Clicking anywhere on Asset Panel no longer deselects assets (not sure if this has already been fixed)
- (16) ❌ addressed in Dashboard improvements (8 Oct 2024) #11268
- (17) Make list of labels in Asset Panel (right sidebar) horizontal instead of (incorrectly) vertical
- (18) Only show "Billing" settings tab for organization admins
- Use "workspace" instead of "network" icon for project tabs
Other fixes:
- Fix Asset Panel (right sidebar) not being able to be toggled off if it is temporarily open (when triggered from editing description, or editing secret, or editing datalink)
- Make "cancel" and "reset" buttons default to outline variant, instead of ghost variant
- Fix style of dropdown
- Change Datalink editor dialog so that object keys are above inputs, not beside them. This gives inputs much more horizontal space for children of deeply nested objects.

Issues left to fix:

Checkboxes currently still cause the dialog to (incorrectly) close
"Edit description" actions etc. do not properly focus inputs

Issues left to do (out of scope):

Show username of user currently using a project (possibly as tooltip?) if the project is currently disabled.
Dropdown and autocomplete entries should be in their own dialog, so that they can escape the parent dialog if they are too long

Important Notes

None

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

~~The documentation has been updated, if necessary.~~
Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
All code follows the
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
~~Unit tests have been written where possible.~~

…yet present on the parent object

…rk as disabled buttons do not show tooltips)

PabloBuchu · 2024-10-04T08:51:48Z

The labels modal. When I hit + next to the asset I get list of all labels (with marked checkboxes) thats ok but:

When I hit create new labels is being created (✅ ) but it is not being associated to the asset I was editing (🔴 ) and the modal is g
Please align colors

one (🔴 ). The newly created label should be appended to the list and associated with asset.

Edit datalink -> Username -> Switch from Text to Enso Secret -> kboom (also no list secrets request is being send)

Asset Panel -> Edit description -> Enter text -> Submit -> Text disapears although after reload all is preserved so the requests is being send properly
| Edit description in context menu should open asset panel with description input active
Can we make the input with active cursor?
| Edit secret should be moved to asset panel (same like datalink)
Yeah that works. Can we unify the forms? Make it to look the same as datalinks?

somebody1234 · 2024-10-04T09:40:55Z

done locally
done locally
will investigate soon
will be fixed on next PR
done locally
done locally (?) more or less at least

somebody1234 · 2024-10-04T10:21:51Z

3: weird, cannot repro?

PabloBuchu · 2024-10-07T08:10:07Z

Sorry but can we use just the same styles for the forms in asset panel? now they look completely different

2. Edit secret -> why reset button? (it resets name and name is readonly) `Update` is enough 3. Here is video for `3.` this looks serious:

Screen.Recording.2024-10-07.at.10.04.26.mp4

somebody1234 · 2024-10-08T06:35:11Z

@PabloBuchu issues should be fixed. the datalink input in the sidebar isn't perfect, but there is a follow on branch that should properly fix this stuff

PabloBuchu · 2024-10-08T10:52:38Z

In secret form you renamed Reset to Cancel but it works the same it clears the name and only way to bring it back is to reload. Lets remove the Cancel button completelty (also in the datalink form it does nothing there as well). Else looks good so I will leave ✅

somebody1234 · 2024-10-08T11:00:35Z

clears the name

yeah my bad. it shouldn't clear the name but will probably fix in the next PR then (which already includes various fixes for forms)

- ⚠️ Follow up to #11219. MUST NOT be merged in before that PR. - Changes: - Add optional overlay to `Popover`s - Add and use `useAssetPassiveListener` everywhere to get reactive updates to asset state even outside Asset Panel - `setItem` has been removed in favor of simply waiting for invalidations - Migrate more `Modal`s to `Popover`s - Migrate more inputs to `Form`s - Periodically refetch Datalink in Asset Panel - Show optimistic state for asset description (adding this because it is trivial to add) - Remove usages of `get*` as mutations throughout the entire codebase - replace with `fetchQuery` - Fixes most of rest of enso-org/cloud-v2#1529 - (1) ℹ️ fixed in #11219 - (2) ❌ backend issue - (3) ❌ out of scope - (4) ❌ backend issue - (5) ❌ out of scope - (6) ❌ [wontfix]? i think this is intentional, it's not so much slow scrolling and moreso snapped scrolling - (7) ❌ backend issue - (8) ℹ️ fixed in #11126 - (9) ❌ out of scope (potentially requires a way to trigger a tooltip on a disabled button) - (10) ❌ (will check later) Make sure you are not able to open a project opened by another user: cmd + click is not always working. - (11) Drag from team space to user space should copy asset - (12) ❌ (will check later) Drag from user space to team should move (and swap ownership) - (13) ℹ️ fixed in #11219 - (14) ℹ️ fixed somewhere (?) - (15) ℹ️ fixed somewhere (?) - (16) Show correct (and up-to-date) description for projects - (17) ℹ️ fixed in #11219 - (18) ℹ️ fixed in #11219 - Fix enso-org/cloud-v2#1535 - Completely remove optimistic UI for "copy asset" - Fix enso-org/cloud-v2#1541 - Make selection brush work again - Unintentionally regressed in 51733ee#diff-f3e29bffcda342ab6a9dbafc58dde88ce26638eaecda1f17f40ca7e319c90cc8L89 # Important Notes None

somebody1234 added 30 commits September 27, 2024 17:15

Switch Asset Panel to tab bar

793cc75

Fix button variant in AssetProjectSession

c5c3ece

Move secret editor to sidebar

241e893

Prevent sidebar from disappearing on Assets Table refresh

efe80b4

WIP: Place labels above inputs in Datalink dialog

4870f9f

Disable "Accessed by projects" and "Accessed data" columns

10c7f27

Unbreak "Manage labels" modal

8beab96

WIP: Add checkbox to "manage labels" dialog

b295a5a

Clean up checkbox list rendering for "manage labels" dialog

e635c73

Simplify Label component

3a877b2

Use named imports in Label

524953f

Merge branch 'develop' into wip/sb/dashboard-improvements-2024-09-24

141aa3e

Horizontal scroll for autocomplete

7418638

Fix Dropdown styling

e8bb3f4

Simplify form cancel buttons

5f496cd

Rename formnovalidate prop to cancel

5ad1fbd

Allow editing children of JSON schema structs even when they are not …

825419f

…yet present on the parent object

Fix closing asset panel if it is currently temporarily open

3bafdf8

Fix centered settings title

c68e01f

Use outline variant for form reset forms ("change password" form)

89d03a7

Use "workspace" icon for project tabs

f4cc0d9

Encode URL when copying cloud URLs as path

3e5b661

Make labels list in Asset Panel (sidebar) horizontal

bb6279e

Only show billing page to organization admins

0692fd9

Add support for tooltip saying who is opeing the project (does not wo…

bc87418

…rk as disabled buttons do not show tooltips)

Add spotlight

bb64e11

Fix spotlight

e9fd335

Treat isEditingDescription as true if spotlight is on description edit

5cad0bc

Setting tags on an asset should invalidate "list directory"

068eba0

Prettier

4897dd6

somebody1234 requested review from Frizi, farmaazon, vitvakatu, kazcw and AdRiley as code owners October 3, 2024 09:47

somebody1234 added 3 commits October 3, 2024 19:59

Move ClearPressResponder to Modal

2eee484

Show path even on Cloud backend

94ec45d

Show error when failing to load directory

76408a9

somebody1234 added 3 commits October 4, 2024 19:09

Make Label color picker full width in "manage labels" modal

1b008e1

Add tag after creating in "manage labels" modal

a63e3eb

Truncate Autocomplete text

a5b4b0a

somebody1234 added 2 commits October 4, 2024 20:08

Fix "new secret" modal

cf5f8af

Autofocus description field when editing

6e182ea

Fix autocomplete input formatting

61d383b

somebody1234 added 2 commits October 8, 2024 16:25

Update styles according to QA

e051d87

Fix crash when editing datalink in right sidebar

0c6be99

somebody1234 mentioned this pull request Oct 8, 2024

Dashboard improvements (8 Oct 2024) #11268

Merged

4 tasks

PabloBuchu approved these changes Oct 8, 2024

View reviewed changes

Remove ability to cancel Asset Panel forms

9651a9e

somebody1234 added the CI: Ready to merge This PR is eligible for automatic merge label Oct 8, 2024

mergify bot merged commit 7a00e6e into develop Oct 9, 2024
37 checks passed

mergify bot deleted the wip/sb/dashboard-improvements-2024-09-24 branch October 9, 2024 09:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dashboard improvements (from 24 September 2024 + 30 September 2024) #11219

Dashboard improvements (from 24 September 2024 + 30 September 2024) #11219

somebody1234 commented Oct 1, 2024 •

edited

Loading

PabloBuchu commented Oct 4, 2024

somebody1234 commented Oct 4, 2024 •

edited

Loading

somebody1234 commented Oct 4, 2024

PabloBuchu commented Oct 7, 2024

somebody1234 commented Oct 8, 2024

PabloBuchu commented Oct 8, 2024

somebody1234 commented Oct 8, 2024 •

edited

Loading

Dashboard improvements (from 24 September 2024 + 30 September 2024) #11219

Dashboard improvements (from 24 September 2024 + 30 September 2024) #11219

Conversation

somebody1234 commented Oct 1, 2024 • edited Loading

Pull Request Description

Important Notes

Checklist

PabloBuchu commented Oct 4, 2024

somebody1234 commented Oct 4, 2024 • edited Loading

somebody1234 commented Oct 4, 2024

PabloBuchu commented Oct 7, 2024

somebody1234 commented Oct 8, 2024

PabloBuchu commented Oct 8, 2024

somebody1234 commented Oct 8, 2024 • edited Loading

somebody1234 commented Oct 1, 2024 •

edited

Loading

somebody1234 commented Oct 4, 2024 •

edited

Loading

somebody1234 commented Oct 8, 2024 •

edited

Loading