Do not run visualizations on InterruptedException #11250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubertp
requested review from
4e6,
JaroslavTulach and
Akirathan
as code owners
hubertp
added
the
CI: No changelog needed
hubertp
changed the title
JaroslavTulach
approved these changes
Oct 4, 2024
| return false; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Is it necessary to introduce new isInterruptedExceptionValue method? Isn't it easier to change the argument of existing isInterruptedException to Object?
There was a problem hiding this comment.
Instance check didn't feel right, hence another method. But I don't have a preference tbh.
There was a problem hiding this comment.
There is no need to perform an instance check. isInterruptedException(Object ex, InteropLibrary iop) accepts Object.
Previously a visualization failure would be reported: ``` Method `+` of type sleep interrupted could not be found. ```
jdunkerley
pushed a commit
that referenced
this pull request
Oct 7, 2024
* Do not run visualizations on InterruptException There is no point in running visualization for the expression value that is InterruptedException. The latter is likely to bubble up the exception or create one that will be confusing to the user. Closes #11243 and partially addresses some of the symptomes of #11084. * Add a test for confusing visualization failures Previously a visualization failure would be reported: ``` Method `+` of type sleep interrupted could not be found. ``` * PR review Nit (cherry picked from commit 9429a45)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
There is no point in running visualization for the expression value that is InterruptedException. The latter is likely to bubble up the exception or create erroneous value that will be confusing to the user.
Important Notes
Closes #11243 and partially addresses some of the symptomes of #11084.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.