Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PoC] Generate IR definitions with annotation processor #11267

Draft
wants to merge 94 commits into
base: develop
Choose a base branch
from

Conversation

Akirathan
Copy link
Member

@Akirathan Akirathan commented Oct 7, 2024

Closes #11498

Pull Request Description

Introduces runtime-parser-processor annotation processor that processes interfaces annotated with @IRNode.

Introduces these 3 new sbt projects:

  • runtime-parser-dsl is a project that contains only the annotation definitions, has no dependencies.
  • runtime-parser-processor is a project that contains the definition of the annotation processor. Has no dependencies.
  • runtime-parser project now depends on runtime-parser-dsl and runtime-parser-processor.

Important Notes

Links to the docs:

Examples of used annotations:

To see the generated code, it is enough to sbt> runtime-parser/compile. All the tests are inside the runtime-parser-processor-test project.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • Run SigTest on runtime-compiler on develop and on this PR.
  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@JaroslavTulach
Copy link
Member

One of the issues with newly generated Java classes is the way to consume them from existing Scala passes. Preferably we do it in a way that doesn't require changes to the existing Scala code. Once I asked

"Knowing how to generate a Java class to be able to apply and unapply it would be great!"

@hubertp has provided following advice when it comes to pattern matching:

package org.enso.compiler.core.ir;

import org.enso.compiler.core.IR;
import org.enso.compiler.core.Identifier;
import scala.Option;
import scala.PartialFunction;
import scala.Tuple2$;
import scala.collection.immutable.List;

import java.util.UUID;
import java.util.function.Function;

public class Foo implements Expression {

    private final Integer a;
    private final String b;

    public Foo(Integer a, String b) {
        this.a = a;
        this.b = b;
    }

    public static scala.Option<scala.Tuple2<Integer, String>> unapply(Object x) {
        if (x instanceof Foo f) {
            return Option.apply(Tuple2$.MODULE$.apply(f.a, f.b));
        } else {
            return Option.empty();
        }
    }

and then

package org.enso.compiler.core.ir

object TestPattern {

  def testMe(x: Object): Unit = {
    x match {
      case Foo(a, b) =>
        println("A " + a + ", B " + b);
      case _ =>
        println("nope")
    }
  }

  def main(args: Array[String]): Unit = {
    testMe(new Foo(1, "foo"))
  }

}

"works just fine" according to @hubertp.

@Akirathan
Copy link
Member Author

An abandoned idea to generate Scala classes is the following commits that are now reverted:

@enso-bot
Copy link

enso-bot bot commented Oct 21, 2024

Pavel Marek reports a new STANDUP for today (2024-10-21):

Progress: - IRProcessor traverser super interfaces and collects all the fields

  • Reverted back to Java class generation It should be finished by 2024-11-07.

@Akirathan Akirathan added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Dec 2, 2024
@Akirathan
Copy link
Member Author

All the required Engine tests are green for the revision that migrated Empty to an interface annotated with @IRNode. This was the very first step that proves that such incremental migration is possible, at least for the simplest possible IR element.

@enso-bot
Copy link

enso-bot bot commented Dec 2, 2024

Pavel Marek reports a new STANDUP for today (2024-12-02):

Progress: - Migrating Empty to a Java interface annotated with @IRNode.

@JaroslavTulach
Copy link
Member

All the required Engine tests are green for the revision that migrated Empty to an interface annotated with @IRNode.

Well, this test is failing and the failure is related.

Shouldn't the DSL dependency be just provided for runtime-parser? That would be the easiest fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate IR definitions by annotation processor
2 participants