Add retries to Data.read #11269
Merged
Add retries to Data.read #11269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A quick solution to random network failures for GET HTTP requests. Should reduce the number of IOExceptions that users see while fetching data.
Previously, we added retries only to fetch HTTP_Request. That was insufficient as intermittent errors might happen while reading body's stream. Enhanced our simple server's crash endpoint to allow for different kind of failures as well as simulate random failures.
Increased the scope of retries in the previous commit.
hubertp
added
the
CI: No changelog needed
hubertp
requested review from
radeusgd,
jdunkerley,
GregoryTravis,
AdRiley,
marthasharkey,
4e6,
JaroslavTulach and
Akirathan
as code owners
jdunkerley
approved these changes
Oct 8, 2024
distribution/lib/Standard/Base/0.0.0-dev/src/Internal/Data_Read_Helpers.enso
Outdated
Show resolved
Hide resolved
GregoryTravis
approved these changes
Oct 8, 2024
distribution/lib/Standard/Base/0.0.0-dev/src/Internal/Data_Read_Helpers.enso
Show resolved
Hide resolved
radeusgd
reviewed
Oct 8, 2024
Comment on lines
24
to
36
| ## PRIVATE | ||
| ADVANCED | ||
| Temporarily cease execution of the current thread. | ||
|
|
||
| Arguments: | ||
| - time: amount of milliseconds to sleep | ||
|
|
||
| > Example | ||
| Sleep the current thread for 1 second. | ||
|
|
||
| Thread.sleep 1000 <| IO.println "I continue!" | ||
| sleep : Integer | ||
| sleep time_in_milliseconds = @Builtin_Method "Thread.sleep" |
There was a problem hiding this comment.
Nice to get this as a builtin, I was always polyglot java import java.lang.Thread, but this seems so much nicer
There was a problem hiding this comment.
I'd rather limit builtins to a bare minimum. Especially something that doesn't have to be fast as sleep doesn't indicate any need to be a builtin.
radeusgd
reviewed
Oct 8, 2024
distribution/lib/Standard/Base/0.0.0-dev/src/Internal/Data_Read_Helpers.enso
Outdated
Show resolved
Hide resolved
radeusgd
reviewed
Oct 8, 2024
engine/runtime/src/main/java/org/enso/interpreter/node/expression/builtin/thread/SleepNode.java
Outdated
Show resolved
Hide resolved
radeusgd
reviewed
Oct 8, 2024
tools/http-test-helper/src/main/java/org/enso/shttp/test_helpers/CrashingTestHandler.java
Outdated
Show resolved
Hide resolved
radeusgd
reviewed
Oct 8, 2024
tools/http-test-helper/src/main/java/org/enso/shttp/test_helpers/CrashingTestHandler.java
Outdated
Show resolved
Hide resolved
radeusgd
approved these changes
Oct 8, 2024
JaroslavTulach
previously requested changes
Oct 9, 2024
distribution/lib/Standard/Base/0.0.0-dev/src/Runtime/Thread.enso
Outdated
Show resolved
Hide resolved
See @radeusgd's response (#11269 (comment)). I'm not the only one who found it missing in the current API. |
hubertp
dismissed
JaroslavTulach’s stale review
engine parts have been removed and this PR is quite important to get in and fix ongoing stability issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This change adds simple retries with exponential backoff. It's very simple and that's on purpose - a more advanced retry mechanism would need to be exposed in the API, which eventually might happen.
For now, this change attempts to address one of the most annoying intermittent failures in GUI, #11084.
Important Notes
No more random failures like:
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.