Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TailCall.TailPosition.NotTail metadata. #11303

Merged
merged 5 commits into from
Oct 11, 2024
Merged

Remove TailCall.TailPosition.NotTail metadata. #11303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
831804c
Remove TailCall.TailPosition.NotTail metadata.
Akirathan Oct 10, 2024
50d5e9c
Fix MatchError
Akirathan Oct 10, 2024
862f8ee
Persistance for TailCall.TailPosition is auto generated
Akirathan Oct 11, 2024
588fe6e
fmt
Akirathan Oct 11, 2024
99eb687
Simplify checking for TailPosition metadata
Akirathan Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 1 addition & 21 deletions engine/runtime-compiler/src/main/java/org/enso/compiler/pass/analyse/PassPersistance.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@
@Persistable(clazz = Graph.Link.class, id = 1266, allowInlining = false)
@Persistable(clazz = TypeInference.class, id = 1280)
@Persistable(clazz = FramePointerAnalysis$.class, id = 1281)
@Persistable(clazz = TailCall$TailPosition$Tail$.class, id = 1282)
public final class PassPersistance {
private PassPersistance() {}

Expand All @@ -90,27 +91,6 @@ protected IgnoredBindings.State readObject(Input in)
}
}

@ServiceProvider(service = Persistance.class)
public static final class PersistTail extends Persistance<TailCall.TailPosition> {
Akirathan marked this conversation as resolved.
Show resolved Hide resolved
public PersistTail() {
super(TailCall.TailPosition.class, true, 1102);
}

@Override
protected void writeObject(TailCall.TailPosition obj, Output out) throws IOException {
out.writeBoolean(obj.isTail());
}

@Override
protected TailCall.TailPosition readObject(Input in)
throws IOException, ClassNotFoundException {
var b = in.readBoolean();
return b
? org.enso.compiler.pass.analyse.TailCall$TailPosition$Tail$.MODULE$
: org.enso.compiler.pass.analyse.TailCall$TailPosition$NotTail$.MODULE$;
}
}

@org.openide.util.lookup.ServiceProvider(service = Persistance.class)
public static final class PersistAliasAnalysisGraphScope extends Persistance<Graph.Scope> {
public PersistAliasAnalysisGraphScope() {
Expand Down
Loading
Loading