Simplify shutdown logic on client disconnect in project-manager #11712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suspend on Windows confuses the reconnection logic and triggers a full shutdown. This change simply drop shutdown on last client disconnect and expects and explicit command.
Minor cherry-picks from the debugging branch. Should reduce the amount of non-critical warnings.
hubertp
added
the
CI: No changelog needed
hubertp
requested review from
4e6,
JaroslavTulach and
Akirathan
as code owners
4e6
approved these changes
Dec 2, 2024
jdunkerley
pushed a commit
that referenced
this pull request
Dec 3, 2024
* Drop soft-shutdown on last client disconnect Suspend on Windows confuses the reconnection logic and triggers a full shutdown. This change simply drop shutdown on last client disconnect and expects and explicit command. * Various cherry-picks Minor cherry-picks from the debugging branch. Should reduce the amount of non-critical warnings. (cherry picked from commit 65010df)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Suspend on Windows confuses the re-connection logic by essentially triggering a full
language server shutdown when waking up from suspend.
This change simply drops logic that delayed shutdown after last client disconnect.
project-manager now expects an explicit request to shutdown.
Partially fixes #11389 (no more app crash). This bug unmasks a bug in GUI where multiple
execution context requests are being made on re-connect.
Partially cherry-picked from experiments in #11518.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.