Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor common SPI logic, handle SPI registrations with missing Enso library #11722

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Nov 29, 2024

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@radeusgd radeusgd added CI: No changelog needed Do not require a changelog entry for this PR. x-refactor Changes that should not be visible to the end-user labels Nov 29, 2024
@radeusgd radeusgd self-assigned this Nov 29, 2024
@radeusgd
Copy link
Member Author

radeusgd commented Nov 29, 2024

Cloud tests:

GitHub
Enso Analytics is a self-service data prep and analysis platform designed for data teams. - Extra Nightly Tests · 162231c

@radeusgd
Copy link
Member Author

When we run the Native Image with the unexpected SPI registrations, we should get 1 warning in the logs per each registration:
image

Base automatically changed from wip/jtulach/Module_Does_Not_Exist to develop November 29, 2024 19:05
@radeusgd radeusgd force-pushed the wip/radeusgd/fix-spi-native-image branch from ea7bd86 to 3f41674 Compare November 29, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. x-refactor Changes that should not be visible to the end-user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native Image run includes SPI for libraries that are not loaded, leading to crashes
1 participant