Quick Editing in Table Editor Widget #12129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farmaazon
requested review from
Frizi,
vitvakatu,
kazcw and
AdRiley
as code owners
🧪 Storybook is successfully deployed!📊 Dashboard:
|
farmaazon
force-pushed
the
wip/farmaazon/table-editor-quick-edit
branch
from
7b21c0e to
28353ef
Compare
farmaazon
force-pushed
the
wip/farmaazon/table-editor-quick-edit
branch
from
00bf71a to
e964474
Compare
…/table-editor-quick-edit
kazcw
approved these changes
Jan 29, 2025
Comment on lines
67
to
71
| suspend: () => { | ||
| return { | ||
| resume: () => syncGridWithEditedCell(), | ||
| } | ||
| }, |
There was a problem hiding this comment.
Does this do anything? A suspend implementation that doesn't capture any state is suspicious.
| for (const [key, comp] of Object.entries(props.components)) { | ||
| class ComponentWrapper implements IHeaderComp { | ||
| private readonly container: HTMLElement = document.createElement('div') | ||
| private handle: VueComponentHandle | undefined | ||
|
|
||
| init(params: IHeaderParams) { | ||
| this.handle = vueHost.register(h(comp, params), this.container) | ||
| console.log('init') |
| @@ -32,11 +32,11 @@ export const [provideWidgetTree, injectWidgetTree] = createContextStore( | |||
| /** TODO: Add docs */ | |||
| export function useCurrentEdit() { | |||
| const currentEditRoot = shallowRef<WidgetEditHandlerRoot>() | |||
| return { | |||
| return proxyRefs({ | |||
There was a problem hiding this comment.
If this is a proxyRefs, we must not destructure it in the call above.
…/table-editor-quick-edit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #10865
The proper "tabbing" cells is implemented in AgGrid, but wasn't visible due to a bug. This PR adds only header edit handling.
"Entering" has our own implementation, as I haven't found a way to configure AgGrid to make behavior described in the task requirements.
Screencast.From.2025-01-29.13-42-00.mp4
Important Notes
The "quick" editing uncovered a problem with our AgGrid updates: the component's refreshing was callled way too often. In this PR it is addressed by reducing reactive dependencies of rowData and columnDefs, so they don't cause updates when only value changes (on value change, we refresh AgGrid by hand: this does not stop editing).
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
[ ] The documentation has been updated, if necessary.Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
[ ] If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,or the Snowflake database integration, a run of the Extra Tests has been scheduled.