Make test dir unique in S3_Spec #12173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregoryTravis
requested review from
jdunkerley,
radeusgd,
AdRiley and
marthasharkey
as code owners
radeusgd
approved these changes
Jan 28, 2025
GregoryTravis
added
the
CI: No changelog needed
…running in parallel
radeusgd
reviewed
Jan 29, 2025
| @@ -62,6 +62,7 @@ with_failure_handler ~failure_action ~action = | |||
| Panic.throw caught_panic | |||
|
|
|||
| result = Panic.catch Any handler=panic_handler action | |||
| IO.println "AAAAA with_failure_handler "+result.catch.to_text | |||
There was a problem hiding this comment.
@GregoryTravis Can we revert this, or do you still need it for some debugging on CI?
AdRiley
approved these changes
Jan 29, 2025
|
Scheduled an Extra Tests run to verify everything is passing: |
GregoryTravis
added
the
CI: Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple instances of S3_Spec running at the same time were writing to the same directory. This generates a unique directory for each run.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.