Mapbox token from current env takes precedence #12389
Open
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farmaazon
requested review from
Frizi,
vitvakatu,
kazcw,
AdRiley,
PabloBuchu,
indiv0,
somebody1234 and
MrFlashAccount
as code owners
jdunkerley
approved these changes
Feb 28, 2025
jdunkerley
added
the
CI: No changelog needed
AdRiley
approved these changes
Feb 28, 2025
🧪 Storybook is successfully deployed!📊 Dashboard:
|
|
Why the changes to MODULE.bazel.lock? |
kazcw
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Before, if the build env contained ENSO_IDE_MAPBOX_API_TOKEN, it was inserted and current env was ignored.
Because we have wrong env set on CI, this effectively blocked mapbox entirely.
After consulting with @jdunkerley we decided that current env should override build env.