Skip to content

Commit

Permalink
refactor: Remove unnecessary Dockerfile lines for installing CMake ve…
Browse files Browse the repository at this point in the history
…rsion 3.23.2
  • Loading branch information
entelecheia committed May 11, 2024
1 parent 84a2416 commit 961c278
Showing 1 changed file with 7 additions and 8 deletions.
15 changes: 7 additions & 8 deletions .docker/Dockerfile.foxy
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,14 @@ ENV AARG ARG_WORKSPACE_ROOT="/workspace"
ENV WORKSPACE_ROOT $ARG_WORKSPACE_ROOT
ENV SCRIPTS_DIR="${APP_INSTALL_ROOT}/scripts"

# Copies scripts from host into the image
RUN mkdir -p "${SCRIPTS_DIR}"
ARG SHELL_SCRIPT="install-cmake.sh"
COPY "./.docker/scripts/${SHELL_SCRIPT}" "${SCRIPTS_DIR}/${SHELL_SCRIPT}"
# Install the latest version of CMake
ARG ARG_CMAKE_VERSION="3.23.2"
ENV CMAKE_VERSION=$ARG_CMAKE_VERSION
RUN bash "${SCRIPTS_DIR}/${SHELL_SCRIPT}"
ENV PATH="${APP_INSTALL_ROOT}/cmake-${CMAKE_VERSION}/bin:${PATH}"
# RUN mkdir -p "${SCRIPTS_DIR}"
# ARG SHELL_SCRIPT="install-cmake.sh"
# COPY "./.docker/scripts/${SHELL_SCRIPT}" "${SCRIPTS_DIR}/${SHELL_SCRIPT}"
# ARG ARG_CMAKE_VERSION="3.23.2"
# ENV CMAKE_VERSION=$ARG_CMAKE_VERSION
# RUN bash "${SCRIPTS_DIR}/${SHELL_SCRIPT}"
# ENV PATH="${APP_INSTALL_ROOT}/cmake-${CMAKE_VERSION}/bin:${PATH}"

# Setting ARGs and ENVs for user creation and workspace setup
ARG ARG_USERNAME="dev"
Expand Down

0 comments on commit 961c278

Please sign in to comment.