Implement custom rego functions for PURL handling #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcarva
reviewed
Nov 21, 2023
mbestavros
force-pushed
the
gh-1053
branch
2 times, most recently
from
ede0261 to
4215a74
Compare
lcarva
reviewed
Nov 21, 2023
mbestavros
force-pushed
the
gh-1053
branch
3 times, most recently
from
44f6d65 to
4a48180
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1173 +/- ##
==========================================
+ Coverage 77.00% 84.45% +7.44%
==========================================
Files 57 66 +9
Lines 4836 5287 +451
==========================================
+ Hits 3724 4465 +741
+ Misses 1112 822 -290
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lcarva
reviewed
Nov 21, 2023
mbestavros
force-pushed
the
gh-1053
branch
2 times, most recently
from
a26a6e5 to
35f0a43
Compare
lcarva
reviewed
Nov 21, 2023
lcarva
reviewed
Nov 21, 2023
Signed-off-by: Mark Bestavros <[email protected]>
lcarva
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two basic custom Rego functions to handle PURLs:
ec.purl.is_validandec.purl.parse.Marking as WIP due to lacking tests.
Resolves #1053.