Refactored the opts into a function & added a back off strategy #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, a new mock, `HttpTransportTimeoutFailure`, has been implemented for testing the backoff strategy in various scenarios. The test case `TestApplicationSnapshotImage_ValidateImageAccess` has been updated to include scenarios where retry mechanisms are triggered and subsequently pass. Resloves: RHTAPBUGS-960 Signed-off-by: Sean Conroy [email protected] Add Backoff Strategy to Application Snapshot Handling Simplified the codebase by centralizing the creation of options into a single function. Enhanced the options configuration by adding a backoff strategy with default parameters. A new mock `HttpTransportTimeoutFailure` has been added to test the backoff strategy under network failure scenarios. Resolves: RHTAPBUGS-960 Signed-off-by: Sean Conroy [email protected]
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1187 +/- ##
==========================================
- Coverage 84.32% 84.31% -0.01%
==========================================
Files 67 67
Lines 5341 5338 -3
==========================================
- Hits 4504 4501 -3
Misses 837 837
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Backoff Strategy to Application Snapshot Handling Simplified the codebase by centralizing the creation of options into a single function. Enhanced the options configuration by adding a backoff strategy with default parameters.
A new mock
HttpTransportTimeoutFailurehas been added to test the backoff strategy under network failure scenarios. Resolves: RHTAPBUGS-960Signed-off-by: Sean Conroy [email protected]