-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt new name in cli docs #2284
Adopt new name in cli docs #2284
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2284 +/- ##
==========================================
+ Coverage 72.77% 72.82% +0.05%
==========================================
Files 89 89
Lines 7676 7694 +18
==========================================
+ Hits 5586 5603 +17
- Misses 2090 2091 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Use the function param consistently instead of accessing the environment var for the same value.
80da8af
to
cdc5da2
Compare
25f7be6
to
d6613b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, but it's not something I'd hold the PR on.
d6613b3
to
0b637a4
Compare
I'll merge this soon. |
Ref: https://issues.redhat.com/browse/EC-1080