Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt new name in cli docs #2284

Merged

Conversation

simonbaird
Copy link
Member

@simonbaird simonbaird commented Jan 25, 2025

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 89.18919% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.82%. Comparing base (46d5c18) to head (0b637a4).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
cmd/fetch/fetch_policy.go 0.00% 2 Missing ⚠️
internal/version/version.go 89.47% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2284      +/-   ##
==========================================
+ Coverage   72.77%   72.82%   +0.05%     
==========================================
  Files          89       89              
  Lines        7676     7694      +18     
==========================================
+ Hits         5586     5603      +17     
- Misses       2090     2091       +1     
Flag Coverage Δ
generative 72.82% <89.18%> (+0.05%) ⬆️
integration 72.82% <89.18%> (+0.05%) ⬆️
unit 72.82% <89.18%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cmd/inspect/inspect_policy.go 67.11% <100.00%> (ø)
cmd/inspect/inspect_policy_data.go 35.45% <100.00%> (ø)
cmd/root/root_cmd.go 51.92% <100.00%> (ø)
cmd/validate/image.go 90.50% <100.00%> (ø)
cmd/validate/input.go 89.80% <100.00%> (ø)
cmd/validate/validate.go 100.00% <100.00%> (ø)
internal/logging/logging.go 45.74% <ø> (ø)
cmd/fetch/fetch_policy.go 0.00% <0.00%> (ø)
internal/version/version.go 91.30% <89.47%> (-0.70%) ⬇️

Use the function param consistently instead of accessing the
environment var for the same value.
@simonbaird simonbaird force-pushed the conforma-rename-first-steps branch from 80da8af to cdc5da2 Compare February 4, 2025 22:11
@simonbaird simonbaird marked this pull request as ready for review February 4, 2025 22:11
@simonbaird simonbaird changed the title Adopt new name in various cli docs Adopt new name in cli docs Feb 4, 2025
@simonbaird simonbaird force-pushed the conforma-rename-first-steps branch 2 times, most recently from 25f7be6 to d6613b3 Compare February 4, 2025 22:23
Copy link
Contributor

@robnester-rh robnester-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, but it's not something I'd hold the PR on.

internal/version/version.go Show resolved Hide resolved
@simonbaird simonbaird force-pushed the conforma-rename-first-steps branch from d6613b3 to 0b637a4 Compare February 5, 2025 14:58
@simonbaird
Copy link
Member Author

I'll merge this soon.

@simonbaird simonbaird merged commit 41bb77a into enterprise-contract:main Feb 5, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants