Fix for Aspect Ratio Support in ZoomTool #132
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aspect ratio was not honored if mouse pointer moved away from a square selection corner. The removed line gets executed in the caller for selection with no aspect ratio.
|
@mik854e Apologies for the delay in reviewing your PR. Could you add more details about the issue that this is fixing (ideally with sample code and/or a unit test)? Thanks much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aspect ratio was not honored if mouse pointer moved away from the square selection corner. The removed line allowed any ROI to be selected outside of the region that was highlighted.
Now, the zoom is set to the highlighted region no matter where the mouse is unclicked.