Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contribute examples to etsdemo #751
Contribute examples to etsdemo #751
Changes from all commits
6d38701
37f3fba
1ddbd95
b4c5757
d9f98dd
e7f579c
1085ce7
f7bb562
bae6661
cdefe9a
6c73f53
97112f6
6096b08
09d8d22
666598a
465747a
2a26868
4cdca8c
157500d
66d7c87
67964ed
55e42f0
0b2ec29
6cd299c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would look / work a lot better as a popup, but that leads to very strange errors due to etsdemo internals. Doing so I get the following error:
we have a trait defined as
a = Instance("B")
whereB
is a class defined elsewhere in the module. However, due to etsdemo messing with locals to change__name__
to___name___
, we end up passing an instance of___name___.B
which traits catches as an invalid value...I do not know how to resolve this. Perhaps we just leave it as demo embedded in the etsdemo ui for now (it is resizable anyway so if you stretch the etsdemo ui out enough you can see the full demo).
@rahulporuri any ideas on how we could resolve this? It is awkward because you need to do
Instance("ModelView")
notInstance(ModelView)
becauseModelView
is defined afterTimerController
in the file, andModelView
also has a trait which isInstance(TimerController)
so we can't simply move the class to be defined above.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ModelView
because that slightly confuses thingsInstance("ModelView")
instead ofInstance(ModelView)
. I think there are definitely valid usecases (like here) where a class is defined later in the module which needs to be used here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note:
switching to
did not solve the issue. I will leave it as a demo not a pop up for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was previously giving an indentation warning inside the etsdemo app