Enforce data array is array in BandedMapper / PolarMapper #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the last bit of changes which need to be pulled from #726
It simply updates
BandedMapper/PolarMapperto follow the lead of their base classLinearMapper.After all these are merged, I will do a final sweep of the code base to see that nothing else needs to be updated with the recent return type changes (plan is to do code base searches for
map_screen, etc. / to go through examples and ensure they all work as expected. Test suite will pass as it has passed on every PR, but just to be sure we didn't miss / break anything in the process not covered by the test suite).