Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Resource functions issues #58

Merged
merged 44 commits into from
May 19, 2017
Merged

Fix Resource functions issues #58

merged 44 commits into from
May 19, 2017

Conversation

itziakos
Copy link
Member

@itziakos itziakos commented May 12, 2017 •
edited
Loading

Changes:

  • Cherry-picked commits from Prepare 0.1.0 release #53
  • Minor cleanup in the tests
  • Augment tests for BeginUpdateResource and EndUpdateResource.
  • Add check_false factories to check specifically for boolean result.
  • Add workaround in check_false for issues with EnumResourseTypesW in wine.
  • Add the function name in the cffi wrappings of kernel32 function to properly populate the error info.
  • Fix UpdateResource to behave like pywin32
  • Fix wine errors

itziakos and others added 24 commits May 12, 2017 18:52
@itziakos
fix typo
192e842 
# Conflicts:
#	win32ctypes/core/ctypes/_common.py
@itziakos
update signatures to follow the pywin32 package
6a9b911
@itziakos
update docstrings
c8e010a
@itziakos
add tests for the BeginUpdate, Update and EndUpdate resource functions
a154415 
# Conflicts:
#	win32ctypes/tests/test_win32api.py
@virtuald @itziakos
LoadResource returns a pointer, use check_null to check the return value
84cb106
@itziakos
add missing changes
41e7450
@itziakos
update windows directory tests
c4754c5
@itziakos
fix expected variable
efdb98a
@itziakos
it should be indentical to what win32api returns
bec8edb
@itziakos
minor cleanup
a886982
@itziakos
make sure that we check the return value of the functions
2f83aac
@itziakos
add a check_false return value function
5d14476
@itziakos
do not use addCleanup for compatibility with 2.6
cce3878
@itziakos
augment the test on begin and end update
2cfa2e0
@itziakos
try to coerce to boolean
4c66fb1
@itziakos
more places where we need to check for false
3a3ee8d
@itziakos
flake8 fixes
6eb7465
@itziakos
more places that need to use check_false
205c1ce
@itziakos
we need to special can the behaviour on wine
6314835
@itziakos
fix check_false function
5dafcd2
@itziakos
fix bad check
731bfff
@itziakos
update ErrorWhen to workaround issues with wine
9a8f06f
@itziakos
set the function_name attribute so that errors have the correct infor…
2ec14ec 
…mation
@itziakos
minor cleanup
8085ac8
@itziakos itziakos mentioned this pull request May 15, 2017
Merged
6 tasks
@itziakos itziakos changed the title [WIP] Fix UpdateResource [WIP] Fix Resource function issues May 15, 2017
@itziakos itziakos changed the title [WIP] Fix Resource function issues [WIP] Fix Resource functions issues May 15, 2017
@codecov-io
Copy link

codecov-io commented May 18, 2017 •
edited
Loading

Codecov Report

Merging #58 into master will increase coverage by 1.78%.
The diff coverage is 97.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
+ Coverage   88.39%   90.18%   +1.78%     
==========================================
  Files          38       38              
  Lines        1017     1049      +32     
  Branches       94       96       +2     
==========================================
+ Hits          899      946      +47     
+ Misses         81       62      -19     
- Partials       37       41       +4
Impacted Files Coverage Δ
win32ctypes/core/cffi/_kernel32.py 100% <100%> (+5.17%) ⬆️
win32ctypes/core/__init__.py 100% <100%> (ø) ⬆️
win32ctypes/pywin32/win32api.py 97.05% <100%> (+9.55%) ⬆️
win32ctypes/core/ctypes/_kernel32.py 94.66% <100%> (-1.34%) ⬇️
win32ctypes/core/ctypes/_util.py 100% <100%> (ø) ⬆️
win32ctypes/core/cffi/_util.py 100% <100%> (ø) ⬆️
win32ctypes/core/ctypes/_common.py 86.95% <85.71%> (+0.59%) ⬆️
build/lib/win32ctypes/core/ctypes/_kernel32.py 94.59% <0%> (-1.36%) ⬇️
build/lib/win32ctypes/core/__init__.py 100% <0%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 178f226...3839894. Read the comment docs.

@itziakos
Copy link
Member Author

appveyor is happy at last https://ci.appveyor.com/project/EnthoughtOSS/pywin32-ctypes/build/1.0.20
Now to see why wine complains

@itziakos
Copy link
Member Author

so the issue is #59

@itziakos itziakos merged commit 676ed94 into master May 19, 2017
@itziakos itziakos changed the title [WIP] Fix Resource functions issues Fix Resource functions issues May 19, 2017
@itziakos itziakos deleted the add-update-release-tests branch May 19, 2017 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itziakos @codecov-io @virtuald