Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Program Configurations MVP #56

Merged
merged 4 commits into from
Jan 18, 2024
Merged

Program Configurations MVP #56

merged 4 commits into from
Jan 18, 2024

Conversation

jakehemmerle
Copy link
Contributor

@jakehemmerle jakehemmerle commented Jan 15, 2024

This adds configurations per #17.

In Programs, the evaluate function now contains an adiitional config: Option<&[u8]> parameter, which is a serialized configuration value. This PR modifies the example-basic-transaction example to include one of these configurations containing a list of whitelisted addresses in a JSON format.

This sets the state for users to be able to reuse or configure a program from a browser, i.e. without having to recompile or upload any Wasm bytecode to the chain.

Breaking:
entropy_programs_runtime::Runtime method evaluate now has an additional parameter of type Option<&[u8]>.

Copy link

vercel bot commented Jan 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
programs 🛑 Canceled (Inspect) Jan 18, 2024 8:30pm

@jakehemmerle jakehemmerle changed the title Program Configurations Program Configurations MVP Jan 15, 2024
@jakehemmerle
Copy link
Contributor Author

@JesseAbram tagging you so you can see what changes to expect

Copy link
Contributor

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things could be tidied up, but generally LGTM 👍

examples/basic-transaction/src/lib.rs Outdated Show resolved Hide resolved
acl/src/lib.rs Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
examples/basic-transaction/src/lib.rs Show resolved Hide resolved
README.md Show resolved Hide resolved
examples/basic-transaction/src/lib.rs Show resolved Hide resolved
jakehemmerle and others added 2 commits January 18, 2024 14:49
Co-authored-by: Hernando Castano <[email protected]>
@jakehemmerle jakehemmerle merged commit 12e6b65 into master Jan 18, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants