-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Program Configurations MVP #56
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1 task
@JesseAbram tagging you so you can see what changes to expect |
JesseAbram
approved these changes
Jan 18, 2024
HCastano
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things could be tidied up, but generally LGTM 👍
Co-authored-by: Hernando Castano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds configurations per #17.
In Programs, the
evaluate
function now contains an adiitionalconfig: Option<&[u8]>
parameter, which is a serialized configuration value. This PR modifies theexample-basic-transaction
example to include one of these configurations containing a list of whitelisted addresses in a JSON format.This sets the state for users to be able to reuse or configure a program from a browser, i.e. without having to recompile or upload any Wasm bytecode to the chain.
Breaking:
entropy_programs_runtime::Runtime
methodevaluate
now has an additional parameter of typeOption<&[u8]>
.