CMakeLists.txt: Always undefine NDEBUG when building LAIK. #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using CMake, the recommend way to get an optimized build is to do a release build via ```-D CMAKE_BUILD_TYPE=Release```. This adds ```-O3``` but also ```-DNDEBUG```, which unfortunately currently breaks LAIK (see issue #92). Therefore, we now always undefine ```NDEBUG``` in the main ```CMakeLists.txt``` file until LAIK is fixed to work with ```NDEBUG```.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using CMake, the recommend way to get an optimized build is to do a
release build via
-D CMAKE_BUILD_TYPE=Release. This adds-O3but also
-DNDEBUG, which unfortunately currently breaks LAIK (seeissue #92). Therefore, we now always undefine
NDEBUGin the mainCMakeLists.txtfile until LAIK is fixed to work withNDEBUG.