Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set unordered head mode to true by default #292

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DenhamPreen
Copy link
Contributor

sorry took me some time to get to this,

I string searched the rollback setting and ammended it where ever I saw that then did a sanity check to see if I might have missed it elsewhere. I'm confident it should be set everywhere but maybe you're aware of somewhere I'm not thinking of :)

@DenhamPreen DenhamPreen requested a review from JonoPrest October 25, 2024 00:15
@DenhamPreen DenhamPreen force-pushed the dp/multichain-unordered-default branch from 094001b to 2cc667b Compare October 25, 2024 00:18
Copy link
Member

@DZakh DZakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a known potential issue with unordered multichain mode and rollback on reorg enabled together, where it might double-process or skip an event on rollback.

@JonoPrest
Copy link
Collaborator

@DenhamPreen, as Dmitry says there's a known potential issue with rollbacks in unordered multichain mode. Can we wait until it's patched before including this in a release?

@DenhamPreen
Copy link
Contributor Author

Sure.
@JonoPrest, could you message me when I can update the branch :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants