Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] mobile/deps: Bump rules_android -> 0.5.1 #37631

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions mobile/.bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,15 @@ build:mobile-remote-release-clang --config=remote
build:mobile-remote-release-clang-android --config=mobile-remote-release-clang
build:mobile-remote-release-clang-android --fat_apk_cpu=x86_64
build:mobile-remote-release-clang-android --linkopt=-fuse-ld=lld
build:mobile-remote-release-clang-android --experimental_google_legacy_api
build:mobile-remote-release-clang-android --experimental_enable_android_migration_apis

build:mobile-remote-release-clang-android-publish --config=mobile-remote-release-clang
build:mobile-remote-release-clang-android-publish --config=mobile-release-android
build:mobile-remote-release-clang-android-publish --fat_apk_cpu=x86,x86_64,armeabi-v7a,arm64-v8a
build:mobile-remote-release-clang-android-publish --linkopt=-fuse-ld=lld


# Compile releases optimizing for size (eg -Os, etc).
build:mobile-release-common --config=sizeopt

Expand Down
15 changes: 15 additions & 0 deletions mobile/WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -99,3 +99,18 @@ load(
provisioning_profile_repository(
name = "local_provisioning_profiles",
)

load("@build_bazel_rules_android//:prereqs.bzl", "rules_android_prereqs")
rules_android_prereqs()
load("@build_bazel_rules_android//:defs.bzl", "rules_android_workspace")
rules_android_workspace()

load("@build_bazel_rules_android//rules:rules.bzl", "android_sdk_repository")
android_sdk_repository(
name = "androidsdk",
)

register_toolchains(
"@build_bazel_rules_android//toolchains/android:android_default_toolchain",
"@build_bazel_rules_android//toolchains/android_sdk:android_sdk_tools",
)
6 changes: 3 additions & 3 deletions mobile/bazel/envoy_mobile_repositories.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def kotlin_repos():
def android_repos():
http_archive(
name = "build_bazel_rules_android",
urls = ["https://github.com/bazelbuild/rules_android/archive/refs/tags/v0.1.1.zip"],
sha256 = "cd06d15dd8bb59926e4d65f9003bfc20f9da4b2519985c27e190cddc8b7a7806",
strip_prefix = "rules_android-0.1.1",
urls = ["https://github.com/bazelbuild/rules_android/archive/refs/tags/v0.5.1.zip"],
sha256 = "b1ddb2db99e1586799f5a6d4c294c79d91e1887059935e26a29d949d9ec21d6a",
strip_prefix = "rules_android-0.5.1",
)