Refresh the version of hessian2-code dependency #38005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new version includes alibaba/hessian2-codec#37 that contains a fix for one of the issues listeed in envoyproxy#37911 (number 5 on the list). TL;DR: the issue is that in hessian2-codec the same cc file is used as a source for two different libraries. The code that depends on both of those libraries at the same time might have an issue because of the same source used several times. Signed-off-by: Mikhail Krinkin <[email protected]>
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
Signed-off-by: Mikhail Krinkin <[email protected]>
RyanTheOptimist
approved these changes
Jan 14, 2025
repokitteh-read-only
bot
removed
the
deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
The new version includes alibaba/hessian2-codec#37 that contains a fix for one of the issues listeed in #37911 (number 5 on the list).
TL;DR: the issue is that in hessian2-codec the same cc file is used as a source for two different libraries. The code that depends on both of those libraries at the same time might have an issue because of the same source used several times.
Additional Description: Related to #37911
Risk Level: Low
Testing:
Tested that Envoy builds with introduced changes, additionally run unit tests in
//test/extensions/common/dubbo/...//test/extensions/filters/network/dubbo_proxy/...and//test/extensions/filters/network/generic_proxy/codecs/dubbo/....dubbo is the extension that uses hessian2 codec (the full test suite will run as part of the PR checks as well).
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a