refactor code

internal/gatewayapi/route.go

@@ -1239,14 +1239,13 @@ func (t *Translator) processDestination(backendRefContext BackendRefContext,
 }
 
 func getBackendFilters(routeType gwapiv1.Kind, backendRefContext BackendRefContext) (backendFilters any) {
+	filters := GetFilters(backendRefContext)
 	switch routeType {
 	case KindHTTPRoute:
-		filters := GetFilters(backendRefContext)
 		if len(filters.([]gwapiv1.HTTPRouteFilter)) > 0 {
 			return filters.([]gwapiv1.HTTPRouteFilter)
 		}
 	case KindGRPCRoute:
-		filters := GetFilters(backendRefContext)
 		if len(filters.([]gwapiv1.GRPCRouteFilter)) > 0 {
 			return filters.([]gwapiv1.GRPCRouteFilter)
 		}

internal/gatewayapi/testdata/httproute-with-invalid-backend-ref-unsupported-filter.out.yaml

@@ -73,7 +73,8 @@ httpRoutes:
         status: "True"
         type: Accepted
       - lastTransitionTime: null
-        message: Specific filter is not supported within BackendRef
+        message: Specific filter is not supported within BackendRef, only RequestHeaderModifier
+          and ResponseHeaderModifier are supported
         reason: UnsupportedRefValue
         status: "False"
         type: ResolvedRefs

internal/gatewayapi/validate.go

@@ -94,39 +94,40 @@ func (t *Translator) validateBackendRefKind(backendRef *gwapiv1a2.BackendRef, pa
 }
 
 func (t *Translator) validateBackendRefFilters(backendRef BackendRefContext, parentRef *RouteParentContext, route RouteContext, routeKind gwapiv1.Kind) bool {
+	filters := GetFilters(backendRef)
+	var unsupportedFilters bool
+
 	switch routeKind {
 	case KindHTTPRoute:
-		filters := GetFilters(backendRef).([]gwapiv1.HTTPRouteFilter)
-		for _, filter := range filters {
+		for _, filter := range filters.([]gwapiv1.HTTPRouteFilter) {
 			if filter.Type != gwapiv1.HTTPRouteFilterRequestHeaderModifier && filter.Type != gwapiv1.HTTPRouteFilterResponseHeaderModifier {
-				t.setRouteStatusCondition(route, parentRef, "UnsupportedRefValue", "Specific filter is not supported within BackendRef")
-				return false
+				unsupportedFilters = true
 			}
 		}
 	case KindGRPCRoute:
-		filters := GetFilters(backendRef).([]gwapiv1.GRPCRouteFilter)
-		for _, filter := range filters {
+		for _, filter := range filters.([]gwapiv1.GRPCRouteFilter) {
 			if filter.Type != gwapiv1.GRPCRouteFilterRequestHeaderModifier && filter.Type != gwapiv1.GRPCRouteFilterResponseHeaderModifier {
-				t.setRouteStatusCondition(route, parentRef, "UnsupportedRefValue", "Specific filter is not supported within BackendRef")
-				return false
+				unsupportedFilters = true
 			}
 		}
 	default:
 		return true
 	}
-	return true
-}
 
-func (t *Translator) setRouteStatusCondition(route RouteContext, parentRef *RouteParentContext, reason gwapiv1.RouteConditionReason, message string) {
-	routeStatus := GetRouteStatus(route)
-	status.SetRouteStatusCondition(routeStatus,
-		parentRef.routeParentStatusIdx,
-		route.GetGeneration(),
-		gwapiv1.RouteConditionResolvedRefs,
-		metav1.ConditionFalse,
-		reason,
-		message,
-	)
+	if unsupportedFilters {
+		routeStatus := GetRouteStatus(route)
+		status.SetRouteStatusCondition(routeStatus,
+			parentRef.routeParentStatusIdx,
+			route.GetGeneration(),
+			gwapiv1.RouteConditionResolvedRefs,
+			metav1.ConditionFalse,
+			"UnsupportedRefValue",
+			"Specific filter is not supported within BackendRef, only RequestHeaderModifier and ResponseHeaderModifier are supported",
+		)
+		return false
+	}
+
+	return true
 }
 
 func (t *Translator) validateBackendNamespace(backendRef *gwapiv1a2.BackendRef, parentRef *RouteParentContext, route RouteContext,