Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add license scan workflow #3407

Merged
merged 2 commits into from
May 16, 2024
Merged

ci: add license scan workflow #3407

merged 2 commits into from
May 16, 2024

Conversation

shahar-h
Copy link
Contributor

What this PR does / why we need it:

  • Added license scan workflow for project dependencies which is aligned with CNCF guidelines.
  • osv-scanner experimental license scanning is used as agreed here.
  • The license scan is running in non-blocking mode since it is currently failing. Once all issues are resolved we can configure it to fail the build. See more details here.
  • The license scan is running together with vulnerability scan. I opened an issue to add support for running only license scan. See more details here.

Which issue(s) this PR fixes:

Fixes #2917

@shahar-h
ci: add license scan workflow
2ae90cc 
Signed-off-by: Shahar Harari <[email protected]>
@shahar-h shahar-h requested a review from a team as a code owner May 16, 2024 21:38
@shahar-h
Copy link
Contributor Author

image

arkodg
arkodg previously approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for driving this !

@shahar-h
fix lint issues
3193469 
Signed-off-by: Shahar Harari <[email protected]>
@shahar-h
Copy link
Contributor Author

/retest

@arkodg arkodg merged commit e5f8630 into envoyproxy:main May 16, 2024
21 checks passed
@shahar-h shahar-h deleted the add-license-scan branch May 17, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zirain zirain zirain approved these changes

@arkodg arkodg arkodg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle OSS licenses and attribution
3 participants
@shahar-h @zirain @arkodg