Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.1] Cherry-pick commits for v1.1.1 #4173

Merged
merged 12 commits into from
Sep 10, 2024
Merged

[release/v1.1] Cherry-pick commits for v1.1.1 #4173

merged 12 commits into from
Sep 10, 2024

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Sep 7, 2024 •
edited
Loading

qicz and others added 9 commits September 6, 2024 18:17
@qicz @Xunzhuo @arkodg
bugfix: fix upstream get unwanted /. (envoyproxy#3990)
1d8c035 
* bugfix: fix upstream get unwanted /.

Signed-off-by: qicz <[email protected]>

* ut for bugfix

Signed-off-by: qicz <[email protected]>

---------

Signed-off-by: qicz <[email protected]>
Co-authored-by: Xunzhuo <[email protected]>
(cherry picked from commit b77f6a4)
Signed-off-by: Arko Dasgupta <[email protected]>
@levikobi @arkodg
feat: gateway http listener isolation (envoyproxy#4000)
ce900c6 
Signed-off-by: Kobi Levi <[email protected]>
(cherry picked from commit 97830e9)
Signed-off-by: Arko Dasgupta <[email protected]>
@ardikabs @arkodg
fix: multiple reference grants in same namespace (envoyproxy#4008)
cf443bb 
* fix: multiple reference grants in same namespace

Signed-off-by: Ardika Bagus <[email protected]>

* test: add e2e test

Signed-off-by: Ardika Bagus <[email protected]>

* chore: wrong service port

Signed-off-by: Ardika Bagus <[email protected]>

---------

Signed-off-by: Ardika Bagus <[email protected]>
(cherry picked from commit b82f4b2)
Signed-off-by: Arko Dasgupta <[email protected]>
@arkodg
reduce readinessProbe failureThreshold and periodSeconds (envoyproxy#…
cbd14ed 
…4021)

* Reduces time for the endpoint to be removed from the endpointSlice
from `30s` (3 * 10) to `5s` (1 * 5)

* Since kube-proxy and CNIs rely on this info and so do external LBs
like GKE https://cloud.google.com/kubernetes-engine/docs/concepts/service-load-balancer

Signed-off-by: Arko Dasgupta <[email protected]>
(cherry picked from commit 67575b8)
Signed-off-by: Arko Dasgupta <[email protected]>
@liorokman @arkodg
fix: add header values as described in the documentation (envoyproxy#…
3190cde 
…4031)

Add header values after splitting the provided value string on ',', like
described in the documentation.

Signed-off-by: Lior Okman <[email protected]>
(cherry picked from commit eac30d6)
Signed-off-by: Arko Dasgupta <[email protected]>
@zirain @arkodg
fix ratelimit statsd not working (envoyproxy#4073)
1d83511 
fix ratelimit statd not working

Signed-off-by: zirain <[email protected]>
(cherry picked from commit 6ab6482)
Signed-off-by: Arko Dasgupta <[email protected]>
@liorokman @arkodg
fix: active http healthcheck documents a default for expected status,…
108b464 
… but doesn't use it (envoyproxy#4090)

If no expected status was explicitly set, use the default value as
described in the documentation.

Signed-off-by: Lior Okman <[email protected]>
(cherry picked from commit 0926b38)
Signed-off-by: Arko Dasgupta <[email protected]>
@TasdidurRahman @arkodg
Fix IsNotFound check for secret and configmap (envoyproxy#4126)
ca4bc61 
fix IsNotFound check for secret and configmap

Signed-off-by: TasdidurRahman <[email protected]>
(cherry picked from commit c20315f)
Signed-off-by: Arko Dasgupta <[email protected]>
@qicz @zirain @arkodg
fix: assign sugar logger name. (envoyproxy#4144)
7ac4aee 
Signed-off-by: qicz <[email protected]>
Co-authored-by: zirain <[email protected]>
(cherry picked from commit b50f5fa)
Signed-off-by: Arko Dasgupta <[email protected]>
@arkodg arkodg requested a review from a team as a code owner September 7, 2024 01:49
@arkodg arkodg requested a review from guydc September 7, 2024 01:50
@arkodg
Copy link
Contributor Author

arkodg commented Sep 7, 2024

note I didnt bring in #4095 since the cherry-pick was non trivial

zirain and others added 2 commits September 6, 2024 18:53
@zirain @arkodg
use sets and return stable result (envoyproxy#4074)
b87b7de 
Signed-off-by: zirain <[email protected]>
(cherry picked from commit 6066f5a)
Signed-off-by: Arko Dasgupta <[email protected]>
@arkodg
delete internal/gatewayapi/clustersettings.go NA for v1.1
9a5e78c 
Signed-off-by: Arko Dasgupta <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Sep 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 62.96296% with 30 lines in your changes missing coverage. Please review.

Project coverage is 67.35%. Comparing base (d5da74f) to head (7b6750d).
Report is 2 commits behind head on release/v1.1.

Files with missing lines Patch % Lines
internal/provider/kubernetes/controller.go 0.00% 19 Missing ⚠️
internal/xds/translator/route.go 57.14% 7 Missing and 2 partials ⚠️
internal/gatewayapi/helpers.go 90.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##           release/v1.1    #4173      +/-   ##
================================================
- Coverage         67.42%   67.35%   -0.07%     
================================================
  Files               183      183              
  Lines             22435    22476      +41     
================================================
+ Hits              15126    15138      +12     
- Misses             6221     6247      +26     
- Partials           1088     1091       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain
Copy link
Contributor

zirain commented Sep 7, 2024

we may need #4175?

@zirain @arkodg
bump to go1.22.7 (envoyproxy#4175)
7b6750d 
* bump to go1.22.6

Signed-off-by: zirain <[email protected]>

* bump to 1.22.7

Signed-off-by: zirain <[email protected]>

---------

Signed-off-by: zirain <[email protected]>
(cherry picked from commit 69bf882)
Signed-off-by: Arko Dasgupta <[email protected]>
@guydc guydc merged commit 9a3f8f7 into envoyproxy:release/v1.1 Sep 10, 2024
21 checks passed
@arkodg arkodg deleted the cherry-pick-v1.1.1 branch September 11, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guydc guydc guydc approved these changes

@zirain zirain zirain approved these changes

@zhaohuabing zhaohuabing zhaohuabing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@arkodg @zirain @zhaohuabing @guydc @qicz @levikobi @ardikabs @liorokman @TasdidurRahman