Add user-facing role definitions for Envoy Gateway and Gateway API

[evankanderson]

What type of PR is this?

feat: Add admin/edit/view namespaced rolebindings for gateway.networking.k8s.io and gateway.envoyproxy.io resources

What this PR does / why we need it:

Adds cluster roles which aggregate to the built-in user-facing cluster roles to allow users with namespace-level admin, edit, or view permissions to view the appropriate Gateway API resources.

Which issue(s) this PR fixes:

I didn't open an issue, but with the default helm chart install and view on a namespace, I get the following error:

$ kubectl get backendtrafficpolicy --context staging -n foo
Error from server (Forbidden): backendtrafficpolicies.gateway.envoyproxy.io is forbidden: User "engineering" cannot list resource "backendtrafficpolicies" in API group "gateway.envoyproxy.io" in the namespace "foo"

Release Notes: Yes

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.45%. Comparing base (6f5ae8e) to head (5468f84).
Report is 134 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4532      +/-   ##
==========================================
- Coverage   65.72%   65.45%   -0.27%     
==========================================
  Files         211      211              
  Lines       31669    31858     +189     
==========================================
+ Hits        20813    20854      +41     
- Misses       9656     9759     +103     
- Partials     1200     1245      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zhaohuabing]

@evankanderson Thanks for adding this. The gen-check check failed. To fix it, could you please run make gen-check loacally and submitted the generate files?

[zhaohuabing]

Should the edit role also be able to view(get list watch) the resources?

[zhaohuabing]

Should we also allow deletecollection ?

[evankanderson]

Good points! Added.

[evankanderson]

Updated, sorry for the delay!

[evankanderson]

... and fixed whatever happened with merges and DCO that made the DCO-bot mad.

[github-actions]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!