listen on ipv4 and ipv6 localhost addrs for admin server #4663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to envoyproxy#4565 Signed-off-by: Arko Dasgupta <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4663 +/- ##
=======================================
Coverage 65.55% 65.55%
=======================================
Files 211 211
Lines 31946 31952 +6
=======================================
+ Hits 20942 20946 +4
Misses 9761 9761
- Partials 1243 1245 +2 ☔ View full report in Codecov by Sentry. |
arkodg
force-pushed
the
admin-listen-dual-stack
branch
from
b6d5fff
to
5fb4b12
Compare
zirain
reviewed
Nov 8, 2024
| @@ -15,8 +15,9 @@ envoyProxyForGatewayClass: | |||
| path: /dev/null | |||
| address: | |||
| socket_address: | |||
| address: 127.0.0.1 | |||
There was a problem hiding this comment.
plan to use this as the default value even for IPv4 cluster?
Signed-off-by: Arko Dasgupta <[email protected]>
arkodg
force-pushed
the
admin-listen-dual-stack
branch
from
5fb4b12
to
9f3356f
Compare
zirain
reviewed
Nov 11, 2024
Comment on lines
+18
to
+20
| address: ::1 | ||
| port_value: 19000 | ||
| ipv4_compat: true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #4565
Release Notes: Yes