fix: decouple gateway status updates from the reconciler

[zhaohuabing]

Fixes: #4845
Release Note: Yes

[codecov]

Codecov Report

Attention: Patch coverage is 76.82927% with 19 lines in your changes missing coverage. Please review.

Project coverage is 66.31%. Comparing base (9b60a67) to head (fb00fb0).

Files with missing lines	Patch %	Lines
internal/provider/kubernetes/controller.go	57.14%	9 Missing ⚠️
internal/provider/kubernetes/status.go	71.42%	4 Missing and 2 partials ⚠️
internal/infrastructure/runner/runner.go	0.00%	2 Missing ⚠️
internal/provider/kubernetes/kubernetes.go	93.33%	0 Missing and 1 partial ⚠️
internal/provider/kubernetes/predicates.go	94.11%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4767      +/-   ##
==========================================
+ Coverage   66.24%   66.31%   +0.06%     
==========================================
  Files         209      209              
  Lines       31922    31950      +28     
==========================================
+ Hits        21148    21188      +40     
+ Misses       9523     9512      -11     
+ Partials     1251     1250       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[arkodg]

were we deadlocking ?

[zhaohuabing]

were we deadlocking ?

It's my suspicion. I can't reproduce this issue, but based on the description of #4685, it seems that the reconciler has been blocked - the pods changes haven't been propogated to the Envoy through xDS, and the only PR in v1.1.3 that might cause blocking is #4337 .

[zirain]

why we need a pointer here?

[zhaohuabing]

internal/infrastructure/runner/runner.go:35:25: copylocks: literal copies lock value from *cfg: github.com/envoyproxy/gateway/internal/infrastructure/runner.Config contains github.com/envoyproxy/gateway/internal/envoygateway/config.Server contains sync.WaitGroup contains sync.noCopy (govet)
        return &Runner{Config: *cfg}

[zhaohuabing]

Verified with #4904.