use a waitGroup instead of an enabled channel in the status updater #4809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use a waitGroup to synchronize to the `Send` method that the status updater is enabled and ready for updates Signed-off-by: Arko Dasgupta <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4809 +/- ##
==========================================
+ Coverage 65.59% 65.65% +0.05%
==========================================
Files 211 211
Lines 32001 31983 -18
==========================================
+ Hits 20992 20999 +7
+ Misses 9767 9747 -20
+ Partials 1242 1237 -5 ☔ View full report in Codecov by Sentry. |
arkodg
changed the title
zhaohuabing
reviewed
Nov 29, 2024
zhaohuabing
approved these changes
Nov 29, 2024
zirain
approved these changes
Nov 29, 2024
zhaohuabing
pushed a commit
to zhaohuabing/gateway
that referenced
this pull request
Nov 29, 2024
…nvoyproxy#4809) use a waitGroup instead of a channel in the status updater * use a waitGroup to synchronize to the `Send` method that the status updater is enabled and ready for updates Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit 36939dc) Signed-off-by: Huabing Zhao <[email protected]>
zhaohuabing
pushed a commit
to zhaohuabing/gateway
that referenced
this pull request
Nov 29, 2024
…nvoyproxy#4809) use a waitGroup instead of a channel in the status updater * use a waitGroup to synchronize to the `Send` method that the status updater is enabled and ready for updates Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit 36939dc) Signed-off-by: Huabing Zhao <[email protected]>
zhaohuabing
added a commit
that referenced
this pull request
Nov 29, 2024
* use a waitGroup instead of an enabled channel in the status updater (#4809) use a waitGroup instead of a channel in the status updater * use a waitGroup to synchronize to the `Send` method that the status updater is enabled and ready for updates Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit 36939dc) Signed-off-by: Huabing Zhao <[email protected]> * fix: remove the default retry policy for jwks fetch (#4802) * remove the default retry policy for jwks fetch Signed-off-by: Huabing Zhao <[email protected]> * fix gen Signed-off-by: Huabing Zhao <[email protected]> * Update release-notes/current.yaml Co-authored-by: Arko Dasgupta <[email protected]> Signed-off-by: Huabing Zhao <[email protected]> --------- Signed-off-by: Huabing Zhao <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> (cherry picked from commit 526a05f) Signed-off-by: Huabing Zhao <[email protected]> --------- Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: Huabing Zhao <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sendmethod that the status updater is enabled and ready for updates