Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new field for customizable JSON request body #1286

Merged

Conversation

Pelinthecoder
Copy link
Contributor

@Pelinthecoder Pelinthecoder commented Feb 3, 2025

Add json_body field to RequestOptions to support dynamic request payloads.

This allows Nighthawk to generate structured request bodies for testing scenarios requiring specific JSON payloads.

@Pelinthecoder Pelinthecoder marked this pull request as draft February 3, 2025 22:11
@Pelinthecoder Pelinthecoder self-assigned this Feb 3, 2025
@fei-deng fei-deng requested review from fei-deng and removed request for fei-deng February 3, 2025 22:31
@fei-deng fei-deng requested a review from jiajunye February 3, 2025 22:35
api/client/options.proto Outdated Show resolved Hide resolved
Signed-off-by: pelinthecoder <[email protected]>
@jiajunye
Copy link
Contributor

jiajunye commented Feb 4, 2025

LGTM

@mum4k mum4k marked this pull request as ready for review February 4, 2025 15:28
@mum4k
Copy link
Collaborator

mum4k commented Feb 4, 2025

/retest

api/client/options.proto Outdated Show resolved Hide resolved
@Pelinthecoder Pelinthecoder requested a review from mum4k February 6, 2025 17:27
@Pelinthecoder Pelinthecoder added the waiting-for-review A PR waiting for a review. label Feb 6, 2025
@fei-deng fei-deng merged commit 1dce61f into envoyproxy:main Feb 6, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-review A PR waiting for a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants