Fully merged #2
Open
Fully merged #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In version 2, aws-sdk started using Seahorse as HTTP Client, and the http_proxy configuration changed from :proxy_uri to :http_proxy The new option can be seen here: https://github.com/aws/aws-sdk-ruby/blob/master/aws-sdk-core/lib/seahorse/client/net_http/connection_pool.rb#L234
Add Version to ActiveRecord::Migration. Required in Rails 5+
Add Version to ActiveRecord::Migration. required in Rails 5+
remove stray comma
Typo correction
correct houndci-bot violations
add a nil check before calling chomp on type_from_file_command
fix test failures
Exception is the root of Ruby's exception hierarchy, so when you rescue Exception you rescue from everything, including subclasses such as SyntaxError, LoadError, and Interrupt etc which is a bad idea. Fix: rescue from StandardError.
FactoryGirl is a factory bot now
1) Principle of least surprise; 2) Paperclip can be used for non-image attachment types, e.g. audio, documents, etc.
If the filename in the header (for any reason) doesn't have quotes, this line throws an error. This fix also matches filenames without quotes. Real world example: ``` Content-Disposition: inline; filename=2125_plg_K1.1_type+C__01.pdf; filename*=UTF-8''2125_plg_K1.1_type+C__01.pdf ``` Throws an error: ``` NoMethodError: undefined method `[]' for nil:NilClass /Users/bas/.rvm/gems/ruby-2.3.3/gems/paperclip-5.1.0/lib/paperclip/io_adapters/uri_adapter.rb:33:in `filename_from_content_disposition' ```
…into fully_merged
…sandfox-im-mk/paperclip into fully_merged
…perclip into fully_merged
…p into fully_merged
|
Fixes are pending. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.