Pull IndigoRecord attribute as the document ID for index updates in bingo-elastic #1987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvaidya
changed the title
|
Made the attribute used for document id configurable - can either provide your own mapper from IndigoRecord to document id (if you want to pull from custom objects), or use IndigoRecord.internalID Also provide optional implementation for auto flushing index |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no way to update existing records in ElasticSearch when calling ElasticRepository.indexRecords in bingo. This leads to lots of duplicate documents being inserted.
This uses the IndigoRecord internalID field as the ID field for the document, so that existing documents can be updated.