Extend from file dist #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 26, 2019 17:42
sbyma
reviewed
Jul 5, 2019
| @@ -117,6 +118,11 @@ int main(int argc, char* argv[]) { | |||
| "Recommended value 900s" | |||
| " [0 (off)]", | |||
| {'c', "checkpoint_interval"}); | |||
| args::ValueFlag<std::string> file_name( | |||
There was a problem hiding this comment.
use a bit more descriptive name, file_name makes following code unclear as to what file its dealing with.
| @@ -270,6 +276,7 @@ int main(int argc, char* argv[]) { | |||
|
|
|||
| std::vector<unique_ptr<Dataset>> datasets; | |||
| agd::Status s; | |||
| std::string input_file_name_temp = args::get(input_file_list); | |||
| if (is_controller) { | ||
| dataset_file_names.push_back(input_file_name_temp); |
There was a problem hiding this comment.
alright i guess give a more descriptive name without the temp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: Enable clustering of a new set of sequences with pre-clustered sequences. The cluster set of pre-clustered sequences should be passed using the
-f <json_file>option.