Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mobile viewing restrictions #471

Merged
merged 2 commits into from
Jan 10, 2025
+4 −43
Merged

Remove mobile viewing restrictions #471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea1e191
Remove mobile viewing restrictions
rygine Jan 10, 2025
f0c4634
Remove e2e testing in CI
rygine Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions .github/workflows/e2e-tests.yml
View file
Open in desktop

This file was deleted.

10 changes: 2 additions & 8 deletions src/pages/inbox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,17 @@ import type { Attachment } from "@xmtp/content-type-remote-attachment";
import { useNavigate } from "react-router-dom";
import { XIcon } from "@heroicons/react/outline";
import { useXmtpStore } from "../store/xmtp";
import { TAILWIND_MD_BREAKPOINT, wipeKeys } from "../helpers";
import { wipeKeys } from "../helpers";
import { FullConversationController } from "../controllers/FullConversationController";
import { AddressInputController } from "../controllers/AddressInputController";
import { HeaderDropdownController } from "../controllers/HeaderDropdownController";
import { MessageInputController } from "../controllers/MessageInputController";
import { SideNavController } from "../controllers/SideNavController";
import { LearnMore } from "../component-library/components/LearnMore/LearnMore";
import useWindowSize from "../hooks/useWindowSize";
import { ConversationListController } from "../controllers/ConversationListController";
import { useAttachmentChange } from "../hooks/useAttachmentChange";
import useSelectedConversation from "../hooks/useSelectedConversation";
import { ReplyThread } from "../component-library/components/ReplyThread/ReplyThread";
import { Mobile } from "../component-library/components/Mobile/Mobile";

const Inbox: React.FC<{ children?: React.ReactNode }> = () => {
const navigate = useNavigate();
Expand Down Expand Up @@ -52,8 +50,6 @@ const Inbox: React.FC<{ children?: React.ReactNode }> = () => {
const activeTab = useXmtpStore((s) => s.activeTab);
const setActiveMessage = useXmtpStore((s) => s.setActiveMessage);

const size = useWindowSize();

const loadingConversations = useXmtpStore(
(state) => state.loadingConversations,
);
Expand Down Expand Up @@ -119,9 +115,7 @@ const Inbox: React.FC<{ children?: React.ReactNode }> = () => {
}
};

return size[0] < TAILWIND_MD_BREAKPOINT ? (
<Mobile />
) : (
return (
// Controller for drag-and-drop area
<div
className={isDragActive ? "bg-slate-100" : "bg-white"}
Expand Down
15 changes: 2 additions & 13 deletions src/pages/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,9 @@ import { useConnectModal } from "@rainbow-me/rainbowkit";
import { useClient } from "@xmtp/react-sdk";
import { useNavigate } from "react-router-dom";
import { OnboardingStep } from "../component-library/components/OnboardingStep/OnboardingStep";
import {
TAILWIND_MD_BREAKPOINT,
classNames,
isAppEnvDemo,
wipeKeys,
} from "../helpers";
import { classNames, isAppEnvDemo, wipeKeys } from "../helpers";
import useInitXmtpClient from "../hooks/useInitXmtpClient";
import { useXmtpStore } from "../store/xmtp";
import { Mobile } from "../component-library/components/Mobile/Mobile";
import useWindowSize from "../hooks/useWindowSize";

const OnboardingPage = () => {
const navigate = useNavigate();
Expand Down Expand Up @@ -54,11 +47,7 @@ const OnboardingPage = () => {
}
}, [status]);

const size = useWindowSize();

return size[0] < TAILWIND_MD_BREAKPOINT ? (
<Mobile />
) : (
return (
<div className={classNames("h-screen", "w-full", "overflow-auto")}>
<OnboardingStep
step={step}
Expand Down
Loading