-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PVA and improve configurability #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@DiamondJoseph I'm aware you are basing some work on this repo right now so thought I'd alert you to some PRs I"m doing. This one is pretty benign but the other one might be more contentious. |
use .env and init container
Make EPICS CA PORTS and the network subnet configurable
gilesknap
changed the title
Standardize the docker/podman checks
Add PVA and improve configurability
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardize docker/podman Checks
re-using code snippets from the latest ioc-template for testing which of podman / docker we should use in scripts. The previous approach of using alias in a bash script was flawed.
Make Ports and Networks Configurable
This allows a user to set the range of ports and the network subnet that is used by the compose project. The configuration is done via a
.env
in the root and changes are propogated to configuration files using an init container.Benefits
https://github.com/epics-containers/example-services/blob/configurable-net/environment.sh#L21-L33
Add PVA support
Add in pvagw and switch to using the PVA plugin for displaying simulation detector data.