Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PVA and improve configurability #17

Merged
merged 14 commits into from
Dec 3, 2024
Merged

Add PVA and improve configurability #17

merged 14 commits into from
Dec 3, 2024

Conversation

gilesknap
Copy link
Member

@gilesknap gilesknap commented Dec 2, 2024

Standardize docker/podman Checks

re-using code snippets from the latest ioc-template for testing which of podman / docker we should use in scripts. The previous approach of using alias in a bash script was flawed.

Make Ports and Networks Configurable

This allows a user to set the range of ports and the network subnet that is used by the compose project. The configuration is done via a .env in the root and changes are propogated to configuration files using an init container.

Benefits

Add PVA support

Add in pvagw and switch to using the PVA plugin for displaying simulation detector data.

@gilesknap
Copy link
Member Author

@DiamondJoseph I'm aware you are basing some work on this repo right now so thought I'd alert you to some PRs I"m doing. This one is pretty benign but the other one might be more contentious.

@gilesknap gilesknap changed the title Standardize the docker/podman checks Add PVA and improve configurability Dec 3, 2024
@gilesknap gilesknap merged commit 391111d into main Dec 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants