Nitpicks for Ch. 10 #401
Merged
Nitpicks for Ch. 10 #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We aren't showing what the warning is, so saying "this warning" is one of those things that works better when you're talking than when you're writing out instructions. By saying "this warning" I thought maybe I was supposed to be able to see the warning itself in the text.
Since the instructions sometimes include "Note: Blah blah blah" I decided to remove the "Note" from Olivia the Owl's comment. Alternatively, she might say "Note that the key only..." but when in doubt, leave it out. I looked and generally she doesn't say "Note: ..."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wahoo! That's all the nitpicks from me for this workshop, one last PR to cap it off.