Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial growth #853

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Fix initial growth #853

merged 3 commits into from
Nov 12, 2024

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Nov 12, 2024

Description

This PR fixes a bug whereby the initial growth was never estimated because of a misnamed argument wrapped inside a purrr::safely call. Not a big deal probably, as this is poorly identified anyway (highly anti-correlated with the number of initial infections) and has a comparatively wide prior sd.

Initial submission checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have tested my changes locally (using devtools::test() and devtools::check()).
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
  • I have followed the established coding standards (and checked using lintr::lint_package()).
  • I have added a news item linked to this PR.

After the initial Pull Request

  • I have reviewed Checks for this PR and addressed any issues as far as I am able.

@sbfnk sbfnk enabled auto-merge November 12, 2024 11:38
NEWS.md Outdated Show resolved Hide resolved
seabbs
seabbs previously approved these changes Nov 12, 2024
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ideal. Looks good.

Co-authored-by: Sam Abbott <[email protected]>
@sbfnk sbfnk disabled auto-merge November 12, 2024 15:20
@sbfnk sbfnk merged commit eeda3f1 into main Nov 12, 2024
9 checks passed
@sbfnk sbfnk deleted the fix-initial-growth branch November 12, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants