Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring alpha_sd docs up to date #862

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Bring alpha_sd docs up to date #862

merged 3 commits into from
Nov 21, 2024

Conversation

zsusswein
Copy link
Contributor

@zsusswein zsusswein commented Nov 20, 2024

Description

This PR closes #861.

Initial submission checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have tested my changes locally (using devtools::test() and devtools::check()).
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
  • I have followed the established coding standards (and checked using lintr::lint_package()).
  • I have added a news item linked to this PR.

This is a docs-only change so I didn't re-run code checks.

After the initial Pull Request

  • I have reviewed Checks for this PR and addressed any issues as far as I am able.

jamesmbaazam
jamesmbaazam previously approved these changes Nov 20, 2024
Copy link
Contributor

@jamesmbaazam jamesmbaazam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zsusswein. LGTM.

@seabbs seabbs enabled auto-merge November 21, 2024 08:16
Co-authored-by: James Azam <[email protected]>
@sbfnk sbfnk requested a review from jamesmbaazam November 21, 2024 14:45
@seabbs seabbs added this pull request to the merge queue Nov 21, 2024
Merged via the queue into epiforecasts:main with commit 1abee6b Nov 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mismatch between alpha_sd default in docs and in code
4 participants