Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break up create_clean_reported_cases() #884

Merged
merged 20 commits into from
Dec 10, 2024
Merged

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Dec 9, 2024

Description

This PR closes #346 by breaking up the create_clean_reported_cases() function into its individual steps that are now separate functions that can be applied at preprocessing stage. After a deprecation cycle this function will be removed.

Doing so will facilitate addressing #640 via the new add_horizon() function that allows users to specify a forecast interval (internal for now, could later be exposed or accessed via forecast_opts() or the like when addressing #867).

It will also facilitate addressing #451 as data passed to functions can be used for plotting as preprocessing happens before calling estimate_infections() and the like.

Initial submission checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have tested my changes locally (using devtools::test() and devtools::check()).
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
  • I have followed the established coding standards (and checked using lintr::lint_package()).
  • I have added a news item linked to this PR.

After the initial Pull Request

  • I have reviewed Checks for this PR and addressed any issues as far as I am able.

R/preprocessing.R Outdated Show resolved Hide resolved
seabbs
seabbs previously approved these changes Dec 9, 2024
R/preprocessing.R Outdated Show resolved Hide resolved
Co-authored-by: Sam Abbott <[email protected]>
sbfnk and others added 2 commits December 9, 2024 14:18
@seabbs seabbs self-requested a review December 9, 2024 14:21
seabbs
seabbs previously approved these changes Dec 9, 2024
@seabbs seabbs enabled auto-merge December 9, 2024 14:22
seabbs
seabbs previously approved these changes Dec 9, 2024
@seabbs
Copy link
Contributor

seabbs commented Dec 9, 2024

I think there is an issue with the message formatting in the depreciation note.

@sbfnk sbfnk linked an issue Dec 9, 2024 that may be closed by this pull request
R/preprocessing.R Outdated Show resolved Hide resolved
R/preprocessing.R Outdated Show resolved Hide resolved
R/preprocessing.R Outdated Show resolved Hide resolved
R/preprocessing.R Outdated Show resolved Hide resolved
@jamesmbaazam
Copy link
Contributor

Might be a task for a separate issue but maybe we should showcase these functions in the examples of the exported functions.

NEWS.md Outdated Show resolved Hide resolved
@sbfnk
Copy link
Contributor Author

sbfnk commented Dec 10, 2024

Passing tests now so just needs someone to approve to enter the merge queue @seabbs @jamesmbaazam

@seabbs seabbs added this pull request to the merge queue Dec 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 10, 2024
@seabbs seabbs added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit e2f0faf Dec 10, 2024
9 checks passed
@seabbs seabbs deleted the break-up-create-clean-reported branch December 10, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add preprocessing_opts() reported_cases_opts()
3 participants