fix error checking for named input

epiforecasts · Jan 2, 2024 · 2253c6b · 2253c6b
1 parent 0d96e56
commit 2253c6b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/R/default-scoring-rules.R b/R/default-scoring-rules.R
@@ -16,7 +16,7 @@
 #' )
 select_rules <- function(rules, select = "all", exclude = NULL) {
   assert_character(x = c(select, exclude), null.ok = TRUE)
-  assert_list(rules, names = TRUE)
+  assert_list(rules, names = "named")
   allowed <- names(rules)
 
   if (select == "all" && is.null(exclude)) {

diff --git a/tests/testthat/test-default-scoring-rules.R b/tests/testthat/test-default-scoring-rules.R
@@ -5,6 +5,11 @@ test_that("`select_rules` works as expected", {
     rules_point()
   )
 
+  expect_equal(
+    scoringutils:::select_rules(rules_point(), select = "all"),
+    scoringutils:::select_rules(rules_point())
+  )
+
   expect_equal(
     names(scoringutils:::select_rules(rules_point(), select = "ape")),
     "ape"