-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #448: Add back in examples for a few plots #463
Conversation
… failing due to changes in `add_coverage()`
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #463 +/- ##
========================================
Coverage 81.87% 81.87%
========================================
Files 20 20
Lines 1677 1677
========================================
Hits 1373 1373
Misses 304 304 ☔ View full report in Codecov by Sentry. |
Summarising what's happening:
As mentioned above, the example for this is the output after running the example code for
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. See comment for thoughts on plot_ranges
/
Closes #448.
Due to previous changes in
add_coverage()
, several plots that used quantiles or interval ranges. My "solution" at the time was to simply comment the code out. This PR adds it back in and updates the examples.The PR is currently blocked by the fact that one function that I used in the example is not currently exported to the user.I didn't want to start using:::
in examples, so I suggest addressing that first before merging this PR.More broadly speaking, there is a question about whether we want to support the function
plot_ranges()
at all and what should happen with it. I created an issue for that, #462