Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #428
As discussed in #428, there were a few duplicate table entries in the metrics table. I initially thought these were caused by the way that the data was constructed, but it turns out the solution was just to call
unique()
on the table before using it in the vignette (because other columns like the name of the function, which make the table non-unique, were removed and are not shown in the vignette)There were additional issues with the table raised by JSS reviewers. These concerned e.g. the orientation of the log score (and making it clear that we're using the negative log likelihood). In addition, I corrected a few spelling and grammatical errors and changed "true value" to "observed value".
We will eventually have to rework this table a bit (see #415 (which is mostly a stub issue at this point)), but I think it makes sense to fix errors now and spend time later to think about how to update the table.